Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prebuilt ICU Analyzer #34958

Merged
merged 10 commits into from
Nov 21, 2018
Merged

Add a prebuilt ICU Analyzer #34958

merged 10 commits into from
Nov 21, 2018

Conversation

romseygeek
Copy link
Contributor

The ICU plugin provides the building blocks of an analysis chain, but doesn't actually have a prebuilt analyzer. It would be a better for users if there was a simple analyzer that they could use out of the box, and also something we can point to from the CJK Analyzer docs as a superior alternative.

Relates to #34285

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@romseygeek
Copy link
Contributor Author

@elasticmachine test this please

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small thing about the default, otherwise I like the idea a lot!

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek
Copy link
Contributor Author

@elasticmachine run docs test please

@romseygeek
Copy link
Contributor Author

@elasticmachine test this please

@romseygeek romseygeek merged commit f6a43b5 into elastic:master Nov 21, 2018
@romseygeek romseygeek deleted the icu_analyzer branch November 21, 2018 09:00
romseygeek added a commit that referenced this pull request Nov 21, 2018
The ICU plugin provides the building blocks of an analysis chain, but doesn't
actually have a prebuilt analyzer. It would be a better for users if there was
a simple analyzer that they could use out of the box, and also something we can
point to from the CJK Analyzer docs as a superior alternative.

Relates to #34285
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Apr 1, 2019
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Apr 4, 2019
russcam added a commit to elastic/elasticsearch-net that referenced this pull request May 8, 2019
russcam added a commit to elastic/elasticsearch-net that referenced this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants