Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of AbstractComponent in server #35444

Merged
merged 2 commits into from
Nov 16, 2018

Conversation

gavlyukovskiy
Copy link
Contributor

Removed extending of AbstractComponent and changed logger usage to
explicit declaration. Abstract classes still have logger
declaration using this.getClass() in order to show implementation class
name in the logs.

See #34488

Removed extending of AbstractComponent and changed logger usage to
explicit declaration. Abstract classes still have logger
declaration using this.getClass() in order to show implementation class
name in its logs.

See elastic#34488
@dliappis dliappis added the :Core/Infra/Core Core issues without another label label Nov 12, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@dliappis
Copy link
Contributor

cc @nik9000

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. I'll kick off a CI job for it once our intake builds have calmed down.

@nik9000
Copy link
Member

nik9000 commented Nov 15, 2018

@elasticmachine, test this please

@nik9000
Copy link
Member

nik9000 commented Nov 16, 2018

@elasticmachine, test this please

@nik9000
Copy link
Member

nik9000 commented Nov 16, 2018

@gavlyukovskiy, the integration test failure looks to have been caused by us bumping the version after releasing 6.5.0. I've merged master into your branch and restarted the build.

@nik9000 nik9000 merged commit 0227260 into elastic:master Nov 16, 2018
@nik9000
Copy link
Member

nik9000 commented Nov 16, 2018

Thanks @gavlyukovskiy! I've merged and am backporting now.

@gavlyukovskiy gavlyukovskiy deleted the server_abstractcomponent branch November 16, 2018 22:58
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Nov 17, 2018
* master: (59 commits)
  SQL: Move internals from Joda to java.time (elastic#35649)
  Add HLRC docs for Get Lifecycle Policy (elastic#35612)
  Align RolloverStep's name with other step names (elastic#35655)
  Watcher: Use joda method to get local TZ (elastic#35608)
  Fix line length for org.elasticsearch.action.* files (elastic#35607)
  Remove use of AbstractComponent in server (elastic#35444)
  Deprecate types in count and msearch. (elastic#35421)
  Refactor an ambigious TermVectorsRequest constructor. (elastic#35614)
  [Scripting] Use Number as a return value for BucketAggregationScript (elastic#35653)
  Removes AbstractComponent from several classes (elastic#35566)
  [DOCS] Add beta warning to ILM pages. (elastic#35571)
  Deprecate types in validate query requests. (elastic#35575)
  Unmute BuildExamplePluginsIT
  Revert "AwaitsFix the RecoveryIT suite - see elastic#35597"
  Revert "[RCI] Check blocks while having index shard permit in TransportReplicationAction (elastic#35332)"
  Remove remaining line length violations for o.e.action.admin.cluster (elastic#35156)
  ML: Adjusing BWC version post backport to 6.6 (elastic#35605)
  [TEST] Replace fields in response with actual values
  Remove usages of CharSequence in Sets (elastic#35501)
  AwaitsFix the RecoveryIT suite - see elastic#35597
  ...
nik9000 pushed a commit that referenced this pull request Nov 19, 2018
Removed extending of AbstractComponent and changed logger usage to
explicit declaration. Abstract classes still have logger
declaration using this.getClass() in order to show implementation class
name in its logs.

See #34488
@nik9000
Copy link
Member

nik9000 commented Nov 19, 2018

Backported!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants