Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCR] Fix follow stats API's follower index filtering feature #36647

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

martijnvg
Copy link
Member

Currently always all follow stats for all follower indices are being
returned even if follow stats for only specific indices are requested.

Currently always all follow stats for all follower indices are being
returned even if follow stats for only specific indices are requested.
@martijnvg martijnvg added >bug v7.0.0 :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v6.6.0 v6.5.4 labels Dec 14, 2018
@martijnvg martijnvg requested a review from dnhatn December 14, 2018 16:29
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @martijnvg.

@martijnvg martijnvg merged commit 68a674e into elastic:master Dec 14, 2018
martijnvg added a commit that referenced this pull request Dec 14, 2018
Currently always all follow stats for all follower indices are being
returned even if follow stats for only specific indices are requested.
martijnvg added a commit that referenced this pull request Dec 14, 2018
Currently always all follow stats for all follower indices are being
returned even if follow stats for only specific indices are requested.
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Mar 21, 2019
Relates: elastic/elasticsearch#36647

This commit fixes the CrossClusterReplicationFollowTests to make assertions based on the
Elasticsearch version under test.

The follower stats API response behaviour changed from 6.5.3 to 6.5.4 - in 6.5.3 and previous, a request to e.g.

GET /<indexname>/_ccr/stats

returns in the `"indices"` array a collection of indices including `<indexname>` but also including other indices that are not `<indexname>` (and are not even a wildcard match for it).

In 6.5.4 and above, that call returns only the single index named `<indexname>` in the `"indices"` array.
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Mar 21, 2019
Relates: elastic/elasticsearch#36647

This commit fixes the CrossClusterReplicationFollowTests to make assertions based on the
Elasticsearch version under test.

The follower stats API response behaviour changed from 6.5.3 to 6.5.4 - in 6.5.3 and previous, a request to e.g.

GET /<indexname>/_ccr/stats

returns in the `"indices"` array a collection of indices including `<indexname>` but also including other indices that are not `<indexname>` (and are not even a wildcard match for it).

In 6.5.4 and above, that call returns only the single index named `<indexname>` in the `"indices"` array.
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Apr 3, 2019
Relates: elastic/elasticsearch#36647

This commit fixes the CrossClusterReplicationFollowTests to make assertions based on the
Elasticsearch version under test.

The follower stats API response behaviour changed from 6.5.3 to 6.5.4 - in 6.5.3 and previous, a request to e.g.

GET /<indexname>/_ccr/stats

returns in the `"indices"` array a collection of indices including `<indexname>` but also including other indices that are not `<indexname>` (and are not even a wildcard match for it).

In 6.5.4 and above, that call returns only the single index named `<indexname>` in the `"indices"` array.

(cherry picked from commit 66cddbc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v6.5.4 v6.6.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants