-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCR] Fix follow stats API's follower index filtering feature #36647
Merged
martijnvg
merged 1 commit into
elastic:master
from
martijnvg:ccr_follow_stats_filtering
Dec 14, 2018
Merged
[CCR] Fix follow stats API's follower index filtering feature #36647
martijnvg
merged 1 commit into
elastic:master
from
martijnvg:ccr_follow_stats_filtering
Dec 14, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently always all follow stats for all follower indices are being returned even if follow stats for only specific indices are requested.
martijnvg
added
>bug
v7.0.0
:Distributed Indexing/CCR
Issues around the Cross Cluster State Replication features
v6.6.0
v6.5.4
labels
Dec 14, 2018
Pinging @elastic/es-distributed |
dnhatn
approved these changes
Dec 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @martijnvg.
martijnvg
added a commit
that referenced
this pull request
Dec 14, 2018
Currently always all follow stats for all follower indices are being returned even if follow stats for only specific indices are requested.
martijnvg
added a commit
that referenced
this pull request
Dec 14, 2018
Currently always all follow stats for all follower indices are being returned even if follow stats for only specific indices are requested.
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Mar 21, 2019
Relates: elastic/elasticsearch#36647 This commit fixes the CrossClusterReplicationFollowTests to make assertions based on the Elasticsearch version under test. The follower stats API response behaviour changed from 6.5.3 to 6.5.4 - in 6.5.3 and previous, a request to e.g. GET /<indexname>/_ccr/stats returns in the `"indices"` array a collection of indices including `<indexname>` but also including other indices that are not `<indexname>` (and are not even a wildcard match for it). In 6.5.4 and above, that call returns only the single index named `<indexname>` in the `"indices"` array.
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Mar 21, 2019
Relates: elastic/elasticsearch#36647 This commit fixes the CrossClusterReplicationFollowTests to make assertions based on the Elasticsearch version under test. The follower stats API response behaviour changed from 6.5.3 to 6.5.4 - in 6.5.3 and previous, a request to e.g. GET /<indexname>/_ccr/stats returns in the `"indices"` array a collection of indices including `<indexname>` but also including other indices that are not `<indexname>` (and are not even a wildcard match for it). In 6.5.4 and above, that call returns only the single index named `<indexname>` in the `"indices"` array.
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Apr 3, 2019
Relates: elastic/elasticsearch#36647 This commit fixes the CrossClusterReplicationFollowTests to make assertions based on the Elasticsearch version under test. The follower stats API response behaviour changed from 6.5.3 to 6.5.4 - in 6.5.3 and previous, a request to e.g. GET /<indexname>/_ccr/stats returns in the `"indices"` array a collection of indices including `<indexname>` but also including other indices that are not `<indexname>` (and are not even a wildcard match for it). In 6.5.4 and above, that call returns only the single index named `<indexname>` in the `"indices"` array. (cherry picked from commit 66cddbc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Distributed Indexing/CCR
Issues around the Cross Cluster State Replication features
v6.5.4
v6.6.0
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently always all follow stats for all follower indices are being
returned even if follow stats for only specific indices are requested.