Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow down the scope of test ignore - awaiting fix #36710

Merged
merged 1 commit into from
Dec 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -492,4 +492,15 @@ private static IndexMetaData newIndexMeta(String name, Settings oldIndexSettings
.build();
return IndexMetaData.builder(name).settings(build).build();
}


@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/36598")
@Override
public void testMustRewrite() throws IOException {
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/36598")
@Override
public void testToQuery() throws IOException {
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,6 @@ protected boolean builderGeneratesCacheableQueries() {
* Test creates the {@link Query} from the {@link QueryBuilder} under test and delegates the
* assertions being made on the result to the implementing subclass.
*/
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/36598")
public void testToQuery() throws IOException {
for (int runs = 0; runs < NUMBER_OF_TESTQUERIES; runs++) {
QueryShardContext context = createShardContext();
Expand Down Expand Up @@ -798,7 +797,6 @@ private static String msg(String left, String right) {
* This test ensures that queries that need to be rewritten have dedicated tests.
* These queries must override this method accordingly.
*/
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/36598")
public void testMustRewrite() throws IOException {
QueryShardContext context = createShardContext();
context.setAllowUnmappedFields(true);
Expand Down