-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Geo] Integrate Lucene's LatLonShape (BKD Backed GeoShapes) as default geo_shape
indexing approach
#36751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit exposes lucene's LatLonShape field as a new strategy in GeoShapeFieldMapper. To use the new indexing approach, strategy should be set to "vector" in the geo_shape field mapper. If the tree parameter is set the mapper will throw an IAE. Note the following: When using vector strategy: * geo_shape query does not support querying by POINT, MULTIPOINT, or GEOMETRYCOLLECTION. * LINESTRING and MULTILINESTRING queries do not support WITHIN relation. * CONTAINS relation is not supported. * The tree, precision, tree_levels, distance_error_pct, and points_only parameters will not throw an exception but they have no effect and will be marked as deprecated.. All other features are supported.
…ror_pct, and points_only
…strategy. Other comment cleanups
…apeFieldMapper Both classes derive from BaseGeoShapeFieldMapper that provides shared parameters: coerce, ignoreMalformed, ignore_z_value, orientation.
…d by the shape builder
…apper to work with double array as a point
nknize
added
>feature
:Analytics/Geo
Indexing, search aggregations of geo points and shapes
:Search Foundations/Mapping
Index mappings, including merging and defining field types
v7.0.0
labels
Dec 18, 2018
Pinging @elastic/es-analytics-geo |
Pinging @elastic/es-search |
jpountz
approved these changes
Dec 18, 2018
tomcallahan
removed
the
:Search Foundations/Mapping
Index mappings, including merging and defining field types
label
Dec 18, 2018
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 18, 2018
* elastic/master: (31 commits) enable bwc tests and switch transport serialization version to 6.6.0 for CAS features [DOCs] Adds ml-cpp PRs to alpha release notes (elastic#36790) Synchronize WriteReplicaResult callbacks (elastic#36770) Add CcrRestoreSourceService to track sessions (elastic#36578) [Painless] Add tests for boxed return types (elastic#36747) Internal: Remove originalSettings from Node (elastic#36569) [ILM][DOCS] Update ILM API authorization docs (elastic#36749) Core: Deprecate use of scientific notation in epoch time parsing (elastic#36691) [ML] Merge the Jindex master feature branch (elastic#36702) Tests: Mute SnapshotDisruptionIT.testDisruptionOnSnapshotInitialization Update versions in SearchSortValues transport serialization Update version in SearchHits transport serialization [Geo] Integrate Lucene's LatLonShape (BKD Backed GeoShapes) as default `geo_shape` indexing approach (elastic#36751) [Docs] Fix error in Common Grams Token Filter (elastic#36774) Fix rollup search statistics (elastic#36674) SQL: Fix wrong appliance of StackOverflow limit for IN (elastic#36724) [TEST] Added more logging Invalidate Token API enhancements - HLRC (elastic#36362) Deprecate types in index API (elastic#36575) Disable bwc tests until elastic#36555 backport is complete (elastic#36737) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes lucene's
LatLonShape
field as the default type inGeoShapeFieldMapper
. To use the new indexing approach, simply set"type" : "geo_shape"
in the mappings without setting any of thestrategy
,precision
,tree_levels
, ordistance_error_pct
parameters. Note the following when using the new indexing approach:geo_shape
query does not support querying byMULTIPOINT
.LINESTRING
andMULTILINESTRING
queries do not yet supportWITHIN
relation. This will be added in the future as abuffered_query
.CONTAINS
relation is not yet supported.tree
,precision
,tree_levels
,distance_error_pct
, andpoints_only
parameters are deprecated.All other
geo_shape
features are supported.relates #35320