Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Remove redundant ILM attributes #36808

Merged
merged 3 commits into from
Dec 20, 2018
Merged

[DOCS] Remove redundant ILM attributes #36808

merged 3 commits into from
Dec 20, 2018

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 19, 2018

Fixes #36797

@lcawl lcawl added >docs General docs changes WIP v7.0.0 :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Dec 19, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@lcawl lcawl added the v6.6.0 label Dec 19, 2018
@jasontedor jasontedor added v6.7.0 and removed v6.6.0 labels Dec 19, 2018
@lcawl lcawl removed the WIP label Dec 20, 2018
jakelandis
jakelandis approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor questions, but LGTM.

docs/reference/ilm/apis/get-status.asciidoc
++++
<titleabbrev>Get {ILM} Status</titleabbrev>
<titleabbrev>Get {ilm} status</titleabbrev>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the change to use the long name is intentional here (as well as other titleabbrev sections) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though if you prefer to have the acronym, I'm not stuck on this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an opinion either way, just double checking this was intentionally.

docs/reference/ilm/apis/get-status.asciidoc
@@ -1,24 +1,24 @@
[role="xpack"]
[testenv="basic"]
[[ilm-get-status]]
=== Get {ILM} Status API
=== Get {ilm} status API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the change to use the long name is intentional here (as well as other header sections) ?

docs/reference/ilm/apis/put-lifecycle.asciidoc
@@ -35,7 +35,7 @@ include::{docdir}/rest-api/timeoutparms.asciidoc[]

You must have the `manage_ilm` cluster privilege to use this API. You must
also have the `manage` index privilege on all indices being managed by `policy`.
All operations executed by {Ilm} for a policy are executed as the user that
All operations executed by {ilm} for a policy are executed as the user that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the lowercase here is intentional. However, I don't see any uses of ilm-cap. (outside the scope of this PR...but should that be removed?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I didn't see why the "I" was capitalized in this case.

@lcawl lcawl merged commit a9834cd into elastic:master Dec 20, 2018
@lcawl lcawl deleted the ilm-attributes branch December 20, 2018 21:34
lcawl added a commit that referenced this pull request Dec 20, 2018
@lcawl
[DOCS] Remove redundant ILM attributes (#36808)
104d6d3
@lcawl lcawl added the v6.6.0 label Dec 20, 2018
lcawl added a commit that referenced this pull request Dec 20, 2018
@lcawl
[DOCS] Remove redundant ILM attributes (#36808)
0495f68
jasontedor added a commit to ywelsch/elasticsearch that referenced this pull request Dec 21, 2018
@jasontedor
Merge remote-tracking branch 'elastic/master' into pr/36137
8de54b8 
* elastic/master: (539 commits)
  SQL: documentation improvements and updates (elastic#36918)
  [DOCS] Merges list of discovery and cluster formation settings (elastic#36909)
  Only compress responses if request was compressed (elastic#36867)
  Remove duplicate paragraph (elastic#36942)
  Fix URI to cluster stats endpoint on specific nodes (elastic#36784)
  Fix typo in unitTest task (elastic#36930)
  RecoveryMonitor#lastSeenAccessTime should be volatile (elastic#36781)
  [CCR] Add `ccr.auto_follow_coordinator.wait_for_timeout` setting (elastic#36714)
  Scripting: Remove deprecated params.ctx (elastic#36848)
  Refactor the REST actions to clarify what endpoints are deprecated. (elastic#36869)
  Add JDK 12 to CI rotation (elastic#36915)
  Improve error message for 6.x style realm settings (elastic#36876)
  Send clear session as routable remote request (elastic#36805)
  [DOCS] Remove redundant ILM attributes (elastic#36808)
  SQL: Fix bug regarding histograms usage in scripting (elastic#36866)
  Update index mappings when ccr restore complete (elastic#36879)
  Docs: Bump version to alpha2 after release
  Enable IPv6 URIs in reindex from remote (elastic#36874)
  Watcher: Remove unused local variable in doExecute (elastic#36655)
  [DOCS] Synchs titles of X-Pack APIs
  ...
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 21, 2018
@jasontedor
Merge branch 'master' into package-ingest-geoip-as-a-module
30d92d1 
* master: (31 commits)
  Move ingest-geoip default databases out of config (elastic#36949)
  [ILM][DOCS] add extra scenario to policy update docs (elastic#36871)
  [Painless] Add String Casting Tests (elastic#36945)
  SQL: documentation improvements and updates (elastic#36918)
  [DOCS] Merges list of discovery and cluster formation settings (elastic#36909)
  Only compress responses if request was compressed (elastic#36867)
  Remove duplicate paragraph (elastic#36942)
  Fix URI to cluster stats endpoint on specific nodes (elastic#36784)
  Fix typo in unitTest task (elastic#36930)
  RecoveryMonitor#lastSeenAccessTime should be volatile (elastic#36781)
  [CCR] Add `ccr.auto_follow_coordinator.wait_for_timeout` setting (elastic#36714)
  Scripting: Remove deprecated params.ctx (elastic#36848)
  Refactor the REST actions to clarify what endpoints are deprecated. (elastic#36869)
  Add JDK 12 to CI rotation (elastic#36915)
  Improve error message for 6.x style realm settings (elastic#36876)
  Send clear session as routable remote request (elastic#36805)
  [DOCS] Remove redundant ILM attributes (elastic#36808)
  SQL: Fix bug regarding histograms usage in scripting (elastic#36866)
  Update index mappings when ccr restore complete (elastic#36879)
  Docs: Bump version to alpha2 after release
  ...
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis jakelandis approved these changes

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes v6.6.0 v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @elasticmachine @jakelandis @jasontedor @jimczi