Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds overview and API ref for cluster voting configurations #36954

Merged
merged 7 commits into from
Jan 7, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 22, 2018

Related to #34714

Adds an overview page for cluster voting configurations and a reference page for the API that manages the exclusion list.

@lcawl lcawl added >docs General docs changes WIP v7.0.0 :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. labels Dec 22, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch ywelsch mentioned this pull request Dec 22, 2018
61 tasks
- add more side-conditions on when the voting configuration shrinks
- add TOC entries for voting (and omitted fault-detection) sections
- add link to voting section from quorum section to define 'voting
  configuration'
- move 'Setting the initial quorum' into voting config section
- minor rewording/whitespace fixes
@DaveCTurner
Copy link
Contributor

@lcawl this looks like a good direction. I made a few changes and pushed 5b608a9 to your branch as it was tricky to express these suggestions in a review. Please feel free to revert or merge that commit as you see fit.

[[voting-config-exclusions]]
== Voting configuration exclusions API
++++
<titleabbrev>Voting Configuration Exclusions</titleabbrev>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the capitalisation of this title to match the other sections under 'Cluster APIs'.

This section describes how {es} uses a quorum-based voting mechanism to
make decisions even if some nodes are unavailable.

<<modules-discovery-voting>>::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this entry.

@@ -40,26 +50,27 @@ module. This module is divided into the following sections:
Cluster state publishing is the process by which the elected master node
updates the cluster state on all the other nodes in the cluster.

<<modules-discovery-quorums>>::
<<cluster-fault-detection>>::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be here, for completeness.

[float]
=== Description

If the <<modules-discovery-settings,`cluster.auto_shrink_voting_configuration`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that mentioning this setting so prominently here will encourage too many users to fiddle with it. It should be left set to the default of true in the overwhelming majority of clusters. We need it to be configurable to support some very unusual resilience requirements, but it's only part of the story for those cases.

I think it'd be better to word most of this description as if the setting is set to the default of true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I've updated the API description to downplay that setting.

@lcawl lcawl removed the WIP label Jan 3, 2019
@DaveCTurner DaveCTurner self-requested a review January 7, 2019 16:36
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@lcawl lcawl merged commit f307847 into elastic:master Jan 7, 2019
@lcawl lcawl deleted the voting branch January 7, 2019 17:11
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 7, 2019
…piration

* elastic/master:
  Removing unused methods in Numbers (elastic#37186)
  Fix setting by time unit (elastic#37192)
  [DOCS] Cleans up xpackml attributes
  ML: fix delayed data annotations on secured cluster (elastic#37193)
  Update version in SearchRequest and related test
  [DOCS] Adds overview and API ref for cluster voting configurations (elastic#36954)
  ML: changing JobResultsProvider.getForecastRequestStats to support > 1 index (elastic#37157)
  Separate out validation of groups of settings (elastic#34184)
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >docs General docs changes v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants