Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Migration test should use different assertions depending on the old cluster version #37077

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

davidkyle
Copy link
Member

MlMigrationFullClusterRestartIT is a full cluster restart test. If the old cluster is v6.6.0 or later then the configurations are already in index documents and don't need to be migrated. This change removes the wait for migration check for those clusters.

The test started failing after the v6.6 branch was cut

Closes #36816

@davidkyle davidkyle added >test-failure Triaged test failures from CI :ml Machine learning v6.7.0 labels Jan 2, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195
Copy link
Contributor

Now that we have two different versions on the 6.6 branch this change needs to be in 6.6 too. I'll backport it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >test-failure Triaged test failures from CI v6.6.1 v6.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants