Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Add protocol tests and remove jdbc_type from drivers response #37516

Merged
merged 3 commits into from
Jan 16, 2019

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Jan 16, 2019

This PR adds tests for the sql protocol by running inline queries for all data types and looking directly at the response on the wire after coming back to the client. Tests are made to go through a wide range of request parameters combinations and making sure all modes are tested.

The same PR removes the jdbc_type element from the response in case of jdbc/odbc.

This fixes #36882 and #36635

Remove jdbc_type element from a response in case of jdbc and odbc.
Added casting to float csv test.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin requested a review from bpintea January 16, 2019 09:19
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nicely done, especially the randomness of request params.

assertQuery("SELECT 'abc123'", "'abc123'", "keyword", "abc123", 0);
}

public void testDates() throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename it to testDateTimes

}

public void testDates() throws IOException {
assertQuery("SELECT CAST('2019-01-14T12:29:25.000Z' AS DATE)", "CAST('2019-01-14T12:29:25.000Z' AS DATE)", "date",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI if #37395 is merged first, change to AS DATETIME.

@astefan
Copy link
Contributor Author

astefan commented Jan 16, 2019

run the gradle build tests 2

@astefan
Copy link
Contributor Author

astefan commented Jan 16, 2019

run the gradle build tests 1

@astefan
Copy link
Contributor Author

astefan commented Jan 16, 2019

:-( run the gradle build tests 1

Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astefan astefan merged commit 659326f into elastic:master Jan 16, 2019
cshtdd added a commit to cshtdd/elasticsearch that referenced this pull request Jan 16, 2019
* master:
  Deprecate _type from LeafDocLookup (elastic#37491)
  Allow system privilege to execute proxied actions (elastic#37508)
  Update Put Watch to allow unknown fields (elastic#37494)
  AwaitsFix testAddNewReplicas
  SQL: Add protocol tests and remove jdbc_type from drivers response (elastic#37516)
  SQL: [Docs] Add an ES-SQL column for data types (elastic#37529)
  IndexMetaData#mappingOrDefault doesn't need to take a type argument. (elastic#37480)
  Simplify + Cleanup Dead Code in Settings (elastic#37341)
  Reject all requests that have an unconsumed body (elastic#37504)
  [Ml] Prevent config snapshot failure blocking migration (elastic#37493)
  Fix line length for aliases and remove suppression (elastic#37455)
  Add SSL Configuration Library (elastic#37287)
  SQL: Remove slightly used meta commands (elastic#37506)
  Simplify Snapshot Create Request Handling (elastic#37464)
  Remove the use of AbstracLifecycleComponent constructor elastic#37488 (elastic#37488)
  [ML] log minimum diskspace setting if forecast fails due to insufficient d… (elastic#37486)
astefan added a commit that referenced this pull request Jan 16, 2019
@astefan astefan deleted the 36882fix branch January 16, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL: add tests to check the protocol stays true to its definition
6 participants