-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix java time epoch date formatters #37829
Merged
spinscale
merged 12 commits into
elastic:master
from
spinscale:1901-fix-epoch-formatting
Feb 1, 2019
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
86593a9
Fix java time epoch date formatters
spinscale 7934c18
Merge branch 'master' into 1901-fix-epoch-formatting
spinscale caca187
added test
spinscale b7e4164
refactor by using a fraction with a minsize of 0
spinscale ff16e37
Merge branch 'master' into 1901-fix-epoch-formatting
spinscale 0757f67
Merge branch 'master' into 1901-fix-epoch-formatting
spinscale 6049d8e
Merge branch 'master' into 1901-fix-epoch-formatting
spinscale 124d5bd
Merge branch 'master' into 1901-fix-epoch-formatting
spinscale da8cffb
Merge branch 'master' into 1901-fix-epoch-formatting
spinscale 812d667
Merge branch 'master' into 1901-fix-epoch-formatting
spinscale 6ac30ec
Merge branch 'master' into 1901-fix-epoch-formatting
spinscale 24c5179
Merge branch 'master' into 1901-fix-epoch-formatting
spinscale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this condition to guard from printing out ".0" when nanos are 0. Why is this being removed? This test passes currently but fails with this PR:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, this one passed for me on java8 and java11 in this PR. Any test setup that I am missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the trick is, that you can have an optional fractional with a length of
0