-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exit code in certutil packaging test #38393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exit code is different on windows, and we don't really care about which code it is, we just need to check that it's not 0 (success)
tvernum
added
>test
Issues or PRs that are addressing/adding tests
v7.0.0
:Security/TLS
SSL/TLS, Certificates
v6.7.0
labels
Feb 5, 2019
Pinging @elastic/es-security |
albertzaharovits
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Feb 6, 2019
The exit code is different on windows, and we don't really care about which code it is, we just need to check that it's not 0 (success) Backport of: elastic#38393
tvernum
added a commit
that referenced
this pull request
Feb 6, 2019
The exit code is different on windows, and we don't really care about which code it is, we just need to check that it's not 0 (success) Backport of: #38393
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 11, 2019
* master: Add an authentication cache for API keys (elastic#38469) Fix exit code in certutil packaging test (elastic#38393) Enable logs for intermittent test failure (elastic#38426) Disable BWC to backport recovering retention leases (elastic#38477) Enable bwc tests now that elastic#38443 is backported. (elastic#38462) Fix Master Failover and DataNode Leave Blocking Snapshot (elastic#38460) Recover retention leases during peer recovery (elastic#38435) Set update mappings mater node timeout to 30 min (elastic#38439) Assert job is not null in FullClusterRestartIT (elastic#38218) Update ilm-api.asciidoc, point to REMOVE policy (elastic#38235) (elastic#38463) SQL: Fix esType for DATETIME/DATE and INTERVALS (elastic#38179) Handle deprecation header-AbstractUpgradeTestCase (elastic#38396) XPack: core/ccr/Security-cli migration to java-time (elastic#38415) Disable bwc tests for elastic#38443 (elastic#38456) Bubble-up exceptions from scheduler (elastic#38317) Re-enable TasksClientDocumentationIT.testCancelTasks (elastic#38234) Allow custom authorization with an authorization engine (elastic#38358) CRUDDocumentationIT fix documentation references Remove support for internal versioning for concurrency control (elastic#38254)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Security/TLS
SSL/TLS, Certificates
>test
Issues or PRs that are addressing/adding tests
v6.7.0
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exit code is different on windows, and we don't really care about
which code it is, we just need to check that it's not 0 (success)
Resolves: #38321
Relates: #37956