Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the clock resolution to millis in GetWatchResponseTests #38405

Merged
merged 3 commits into from
Feb 5, 2019
Merged

Fix the clock resolution to millis in GetWatchResponseTests #38405

merged 3 commits into from
Feb 5, 2019

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Feb 5, 2019

the clock resolution changed from jdk8->jdk10, hence the test is passing
in jdk8 but failing in jdk10. The Watcher's objects are serialised and
deserialised with milliseconds precision, making test to fail in jdk 10
and higher

closes #38400

@pgomulka
Fix the clock resolution to millis in GetWatchResponseTests
f74b3c6 
the clock resolution changed from jdk8->jdk10, hence the test is passing
in jdk8 but failing in jdk10. The Watcher's objects are serialised and
deserialised with milliseconds precision, making test to fail in jdk 10
and higher

closes elastic#38400
@pgomulka pgomulka added >test-failure Triaged test failures from CI :Data Management/Watcher labels Feb 5, 2019
@pgomulka pgomulka self-assigned this Feb 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

spinscale
spinscale approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@spinscale spinscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one nit. Happy, when CI is happy

...lugin/core/src/test/java/org/elasticsearch/protocol/xpack/watcher/GetWatchResponseTests.java Outdated
ZonedDateTime lastChecked = rarely() ? null : ZonedDateTime.now(ZoneOffset.UTC);
ZonedDateTime lastMetCondition = rarely() ? null : ZonedDateTime.now(ZoneOffset.UTC);

//Instant.ofEpochMilli(fixedClock.millis()).atZone(ZoneOffset.UTC);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover?

@pgomulka pgomulka merged commit 963b474 into elastic:master Feb 5, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 5, 2019
@jasontedor
Merge branch 'master' into retention-leases-recovery
d010f37 
* master: (23 commits)
  Lift retention lease expiration to index shard (elastic#38380)
  Make Ccr recovery file chunk size configurable (elastic#38370)
  Prevent CCR recovery from missing documents (elastic#38237)
  re-enables awaitsfixed datemath tests (elastic#38376)
  Types removal fix FullClusterRestartIT warnings (elastic#38445)
  Make sure to reject mappings with type _doc when include_type_name is false. (elastic#38270)
  Updates the grok patterns to be consistent with logstash (elastic#27181)
  Ignore type-removal warnings in XPackRestTestHelper (elastic#38431)
  testHlrcFromXContent() should respect assertToXContentEquivalence() (elastic#38232)
  add basic REST test for geohash_grid (elastic#37996)
  Remove DiscoveryPlugin#getDiscoveryTypes (elastic#38414)
  Fix the clock resolution to millis in GetWatchResponseTests (elastic#38405)
  Throw AssertionError when no master (elastic#38432)
  `if_seq_no` and `if_primary_term` parameters aren't wired correctly in REST Client's CRUD API (elastic#38411)
  Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale (elastic#38394)
  Fix failures in BulkProcessorIT#testGlobalParametersAndBulkProcessor. (elastic#38129)
  SQL: Implement CURRENT_DATE (elastic#38175)
  Mute testReadRequestsReturnLatestMappingVersion (elastic#38438)
  [ML] Report index unavailable instead of waiting for lazy node (elastic#38423)
  Update Rollup Caps to allow unknown fields (elastic#38339)
  ...
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Feb 6, 2019
@droberts195
Fix the clock resolution to millis in ScheduledEventTests
8196eee 
The clock resolution changed from jdk8 to jdk10, hence the
test is passing in jdk8 but failing in jdk10.  Scheduled
events are serialised and deserialised with millisecond
precision, making test fail in jdk 10 and higher.

Fixes a problem introduced by elastic#38415 and the fix is
identical to the one that was made in elastic#38405.
@droberts195 droberts195 mentioned this pull request Feb 6, 2019
Merged
droberts195 added a commit that referenced this pull request Feb 6, 2019
@droberts195
Fix the clock resolution to millis in ScheduledEventTests (#38506)
bf73671 
The clock resolution changed from jdk8 to jdk10, hence the
test is passing in jdk8 but failing in jdk10.  Scheduled
events are serialised and deserialised with millisecond
precision, making test fail in jdk 10 and higher.

Fixes a problem introduced by #38415 and the fix is
identical to the one that was made in #38405.
@pgomulka pgomulka mentioned this pull request Feb 6, 2019
Closed
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Feb 6, 2019
@droberts195
Fix the clock resolution to millis in ScheduledEventTests (elastic#38506
9009637 
)

The clock resolution changed from jdk8 to jdk10, hence the
test is passing in jdk8 but failing in jdk10.  Scheduled
events are serialised and deserialised with millisecond
precision, making test fail in jdk 10 and higher.

Fixes a problem introduced by elastic#38415 and the fix is
identical to the one that was made in elastic#38405.
@droberts195 droberts195 mentioned this pull request Feb 6, 2019
Closed
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Feb 6, 2019
@droberts195
Fix the clock resolution to millis in ScheduledEventTests (elastic#38506
8051651 
)

The clock resolution changed from jdk8 to jdk10, hence the
test is passing in jdk8 but failing in jdk10.  Scheduled
events are serialised and deserialised with millisecond
precision, making test fail in jdk 10 and higher.

Fixes a problem introduced by elastic#38415 and the fix is
identical to the one that was made in elastic#38405.
@droberts195 droberts195 mentioned this pull request Feb 6, 2019
Merged
alpar-t pushed a commit to jasontedor/elasticsearch that referenced this pull request Feb 7, 2019
@droberts195 @alpar-t
Fix the clock resolution to millis in ScheduledEventTests (elastic#38506
41e4982 
)

The clock resolution changed from jdk8 to jdk10, hence the
test is passing in jdk8 but failing in jdk10.  Scheduled
events are serialised and deserialised with millisecond
precision, making test fail in jdk 10 and higher.

Fixes a problem introduced by elastic#38415 and the fix is
identical to the one that was made in elastic#38405.
droberts195 added a commit that referenced this pull request Feb 8, 2019
@droberts195
Fix the clock resolution to millis in ScheduledEventTests (#38517)
2bee3cc 
The clock resolution changed from jdk8 to jdk10, hence the
test is passing in jdk8 but failing in jdk10.  Scheduled
events are serialised and deserialised with millisecond
precision, making test fail in jdk 10 and higher.

Fixes a problem introduced by #38415 and the fix is
identical to the one that was made in #38405.

Backport of #38506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spinscale spinscale spinscale approved these changes

Assignees
No one assigned
Labels
:Data Management/Watcher >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetWatchResponseTests failing when running jdk11
3 participants
@pgomulka @elasticmachine @spinscale