Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Fips #38546

Merged

Conversation

andyb-elastic
Copy link
Contributor

testing convetions need to be disabled if the test task is for fips.

This is a cherry-pick of 6a5f3f0 which fixed this on master. This was failing on 6.x and so now fails on 6.7

Closes #38322 and #37697

testing convetions need to be disabled if the test task is for fips.
@andyb-elastic andyb-elastic added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label backport v6.7.0 labels Feb 6, 2019
@andyb-elastic andyb-elastic requested a review from alpar-t February 6, 2019 22:55
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@jkakavas jkakavas self-requested a review February 7, 2019 09:59
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Andy, thanks for taking care of this

@andyb-elastic andyb-elastic merged commit 293ed6d into elastic:6.7 Feb 7, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 8, 2019
* 6.7:
  Fix build on Fips (elastic#38546)
  ML: update set_upgrade_mode, add logging (elastic#38372) (elastic#38539)
  Update 'removal of types' docs to reflect the new plan. (elastic#38548)
  Make the 'get templates' types deprecation message consistent. (elastic#38532)
  Add API key settings documentation (elastic#38490) (elastic#38499)
  Mute testExpiredApiKeysDeletedAfter1Week in 6.7 (elastic#38528)
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Apr 11, 2019
* This is currently failing with:

```
Test classes are not included in any enabled task (:modules:reindex:test):
  * org.elasticsearch.client.documentation.ReindexDocumentationIT
  * org.elasticsearch.index.reindex.ManyDocumentsIT
  * org.elasticsearch.index.reindex.ReindexClientYamlTestSuiteIT
  * org.elasticsearch.index.reindex.ReindexWithoutContentIT
  * org.elasticsearch.index.reindex.remote.ReindexFromOldRemoteIT
```

* Same fix as in elastic#38546
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Apr 11, 2019
* This is currently failing with:

```
Test classes are not included in any enabled task (:modules:reindex:test):
  * org.elasticsearch.client.documentation.ReindexDocumentationIT
  * org.elasticsearch.index.reindex.ManyDocumentsIT
  * org.elasticsearch.index.reindex.ReindexClientYamlTestSuiteIT
  * org.elasticsearch.index.reindex.ReindexWithoutContentIT
  * org.elasticsearch.index.reindex.remote.ReindexFromOldRemoteIT
```

* Same fix as in elastic#38546
original-brownbear added a commit that referenced this pull request Apr 11, 2019
* This is currently failing with:

```
Test classes are not included in any enabled task (:modules:reindex:test):
  * org.elasticsearch.client.documentation.ReindexDocumentationIT
  * org.elasticsearch.index.reindex.ManyDocumentsIT
  * org.elasticsearch.index.reindex.ReindexClientYamlTestSuiteIT
  * org.elasticsearch.index.reindex.ReindexWithoutContentIT
  * org.elasticsearch.index.reindex.remote.ReindexFromOldRemoteIT
```

* Same fix as in #38546
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
* This is currently failing with:

```
Test classes are not included in any enabled task (:modules:reindex:test):
  * org.elasticsearch.client.documentation.ReindexDocumentationIT
  * org.elasticsearch.index.reindex.ManyDocumentsIT
  * org.elasticsearch.index.reindex.ReindexClientYamlTestSuiteIT
  * org.elasticsearch.index.reindex.ReindexWithoutContentIT
  * org.elasticsearch.index.reindex.remote.ReindexFromOldRemoteIT
```

* Same fix as in elastic#38546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Security/Security Security issues without another label >test Issues or PRs that are addressing/adding tests v7.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants