Un-mute and fix BuildExamplePluginsIT #38899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There doesn't seem to be anything wrong with the test iteself. I think the failure were CI performance related, but while it was muted, some failures managed to sneak in. Closes elastic#38784
alpar-t
added
:Delivery/Build
|
Pinging @elastic/es-core-infra |
|
@elasticmachine run elasticsearch-ci/oss-distro-docs |
jaymode
approved these changes
Feb 14, 2019
mark-vieira
requested changes
Feb 27, 2019
| @@ -39,6 +39,7 @@ import org.gradle.api.logging.Logger | |||
| import org.gradle.api.tasks.Copy | |||
| import org.gradle.api.tasks.Delete | |||
| import org.gradle.api.tasks.Exec | |||
| import org.gradle.internal.os.OperatingSystem | |||
There was a problem hiding this comment.
Looks like this import is unused.
| @@ -16,6 +16,7 @@ | |||
| * specific language governing permissions and limitations | |||
| * under the License. | |||
| */ | |||
| apply plugin: "nebula.maven-scm" | |||
There was a problem hiding this comment.
Applying this plugin twice now.
mark-vieira
approved these changes
Feb 28, 2019
alpar-t
added a commit
that referenced
this pull request
Mar 4, 2019
* Un-mute and fix BuildExamplePluginsIT There doesn't seem to be anything wrong with the test iteself. I think the failure were CI performance related, but while it was muted, some failures managed to sneak in. Closes #38784 * PR review
alpar-t
added a commit
that referenced
this pull request
Mar 4, 2019
* Un-mute and fix BuildExamplePluginsIT There doesn't seem to be anything wrong with the test iteself. I think the failure were CI performance related, but while it was muted, some failures managed to sneak in. Closes #38784 * PR review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be anything wrong with the test iteself.
I think the failure were CI performance related, but while it was muted,
some failures managed to sneak in.
@jaymode , @tvernum note that this does fix the test, but users will still not be able to run it unless we publish the specific jars to maven central. This is done by the release manager.
The
apply plugin: "nebula.maven-scm"causes the POMs to be generated so RM can publish them, but the RM config still needs to be updated.This is necessary to make it possible for users to get to all the dependencies of the example plugin, including transitive dependencies.
The reason this works in the regular build is that all the dependencies are taken from the current build, but the example plugins are also meant to be built outside the build.
Closes #38784