-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce global checkpoint sync interval in disruption tests #38931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
Issues or PRs that are addressing/adding tests
v7.0.0
:Distributed Indexing/Distributed
A catch all label for anything in the Distributed Area. Please avoid if you can.
v8.0.0
v7.2.0
v6.6.2
labels
Feb 14, 2019
Pinging @elastic/es-distributed |
jasontedor
approved these changes
Feb 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ywelsch
approved these changes
Feb 15, 2019
Thanks @jasontedor @ywelsch! |
dnhatn
added a commit
that referenced
this pull request
Feb 15, 2019
We verify seq_no_stats is aligned between copies at the end of some disruption tests. Sometimes, the assertion `assertSeqNos` is tripped due to a lagged global checkpoint on replicas. The global checkpoint on replicas is lagged because we sync the global checkpoint 30 seconds (by default) after the last replication operation. This change reduces the global checkpoint sync-internal to 1s in the disruption tests. Closes #38318 Closes #36789
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 15, 2019
* master: Address some CCR REST test case flakiness (elastic#38975) Edits to text in Completion Suggester doc (elastic#38980) SQL: doc polishing [DOCS] Fixes broken formatting SQL: Polish the rest chapter (elastic#38971) Remove `nGram` and `edgeNGram` token filter names (elastic#38911) Add an exception throw if waiting on transport port file fails (elastic#37574) Improve testcluster distribution artifact handling (elastic#38933) Advance max_seq_no before add operation to Lucene (elastic#38879) Reduce global checkpoint sync interval in disruption tests (elastic#38931) [test] disable packaging tests for suse boxes Relax testStressMaybeFlushOrRollTranslogGeneration (elastic#38918) [DOCS] Edits warning in put watch API (elastic#38582) Fix serialization bug in ShardFollowTask after cutting this class over to extend from ImmutableFollowParameters. [DOCS] Updates methods for upgrading machine learning (elastic#38876)
dnhatn
added a commit
that referenced
this pull request
Feb 15, 2019
We verify seq_no_stats is aligned between copies at the end of some disruption tests. Sometimes, the assertion `assertSeqNos` is tripped due to a lagged global checkpoint on replicas. The global checkpoint on replicas is lagged because we sync the global checkpoint 30 seconds (by default) after the last replication operation. This change reduces the global checkpoint sync-internal to 1s in the disruption tests. Closes #38318 Closes #36789
dnhatn
added a commit
that referenced
this pull request
Feb 16, 2019
We verify seq_no_stats is aligned between copies at the end of some disruption tests. Sometimes, the assertion `assertSeqNos` is tripped due to a lagged global checkpoint on replicas. The global checkpoint on replicas is lagged because we sync the global checkpoint 30 seconds (by default) after the last replication operation. This change reduces the global checkpoint sync-internal to 1s in the disruption tests. Closes #38318 Closes #36789
dnhatn
added a commit
that referenced
this pull request
Feb 16, 2019
We verify seq_no_stats is aligned between copies at the end of some disruption tests. Sometimes, the assertion `assertSeqNos` is tripped due to a lagged global checkpoint on replicas. The global checkpoint on replicas is lagged because we sync the global checkpoint 30 seconds (by default) after the last replication operation. This change reduces the global checkpoint sync-internal to 1s in the disruption tests. Closes #38318 Closes #36789
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
AbstractDisruptionTestCase set a lower global checkpoint sync interval setting, but this was ignored by testAckedIndexing, which has led to spurious test failures Relates elastic#41068, elastic#38931
seut
added a commit
to crate/crate
that referenced
this pull request
Aug 29, 2019
This should remove flakiness of the cluster disruption integration tests. See elastic/elasticsearch#38931 and elastic/elasticsearch@d49d9b5
seut
added a commit
to crate/crate
that referenced
this pull request
Aug 29, 2019
This should remove flakiness of the cluster disruption integration tests. See elastic/elasticsearch#38931 and elastic/elasticsearch@d49d9b5
seut
added a commit
to crate/crate
that referenced
this pull request
Aug 30, 2019
This should remove flakiness of the cluster disruption integration tests. See elastic/elasticsearch#38931 and elastic/elasticsearch@d49d9b5
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Aug 30, 2019
This should remove flakiness of the cluster disruption integration tests. See elastic/elasticsearch#38931 and elastic/elasticsearch@d49d9b5
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Aug 30, 2019
This should remove flakiness of the cluster disruption integration tests. See elastic/elasticsearch#38931 and elastic/elasticsearch@d49d9b5 (cherry picked from commit 724c075) # Conflicts: # sql/src/main/java/io/crate/analyze/TableParameters.java
seut
added a commit
to crate/crate
that referenced
this pull request
Aug 30, 2019
This should remove flakiness of the cluster disruption integration tests. See elastic/elasticsearch#38931 and elastic/elasticsearch@d49d9b5 (cherry picked from commit 724c075) # Conflicts: # sql/src/main/java/io/crate/analyze/TableParameters.java
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Aug 30, 2019
This should remove flakiness of the cluster disruption integration tests. See elastic/elasticsearch#38931 and elastic/elasticsearch@d49d9b5 (cherry picked from commit 724c075) # Conflicts: # sql/src/main/java/io/crate/analyze/TableParameters.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Indexing/Distributed
A catch all label for anything in the Distributed Area. Please avoid if you can.
>test
Issues or PRs that are addressing/adding tests
v6.6.2
v6.7.0
v7.0.0-rc2
v7.2.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We verify seq_no_stats is aligned between copies at the end of some disruption tests. Sometimes, the assertion
assertSeqNos
is tripped due to a lagged global checkpoint on replicas. This happens because the global checkpoint is synced 30 seconds (by default) after the last replication operation. This change reduces the global checkpoint sync-internal to 1s in the disruption tests.Closes #38318
Closes #36789