Fix simple query string serialization conditional #38960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like elastic#21504 introduced a serialization conditional for lenientSet, but the PR was never backported to 5.x hence whenever simple query string is serialized between 6.x and 5.6, it can't be read/written properly causing errors on the transport layer. This commit updates the conditional to only read/write the field against 6.0+ versions which are aware of it. Closes elastic#38889
javanna
added
>bug
:Search/Search
|
Pinging @elastic/es-search |
jimczi
approved these changes
Feb 15, 2019
| } | ||
| } | ||
|
|
||
| public void testReadFrom_5_6() throws IOException { |
There was a problem hiding this comment.
We should add a simple rest test for the simple_query_string as a follow up in master. This would have caught this bug if we had one.
There was a problem hiding this comment.
right, this unit test would have failed if we had it, but it only catches the bug when reading on 6.7 something that was written on 5.6. The other way around is much harder to test in 6.x cause we don't really have the reading code from 5.6.
javanna
added a commit
that referenced
this pull request
Feb 16, 2019
Looks like #21504 introduced a serialization conditional for lenientSet, but the PR was never backported to 5.x hence whenever simple query string is serialized between 6.x and 5.6, it can't be read/written properly causing errors on the transport layer. This commit updates the conditional to only read/write the field against 6.0+ versions which are aware of it. Closes #38889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #21504 introduced a serialization conditional for lenientSet,
but the PR was never backported to 5.x hence whenever simple query
string is serialized between 6.x and 5.6, it can't be read/written properly causing errors on the transport layer.
This commit updates the conditional to only read/write the field against
6.0+ versions which are aware of it.
Closes #38889