Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Unset machine learning upgrade mode #39149

Merged
merged 3 commits into from
Feb 20, 2019
Merged

[DOCS] Unset machine learning upgrade mode #39149

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31fd91f
[DOCS] Unset ML upgrade mode
lcawl Feb 19, 2019
84dbc8a
[DOCS] Teardown example
lcawl Feb 19, 2019
bd930fa
[DOCS] Fixes placement of teardown
lcawl Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion docs/reference/upgrade/close-ml.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,14 @@ POST _ml/set_upgrade_mode?enabled=true
This method does not persist the absolute latest model state, rather it uses the
last model state that was automatically saved. By halting the tasks, you avoid
incurring the cost of managing active jobs during the upgrade and it's quicker
than stopping {dfeeds} and closing jobs.
than stopping {dfeeds} and closing jobs.

//////////////////////////

[source,js]
--------------------------------------------------
POST /_ml/set_upgrade_mode?enabled=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd be better off clearing this with // TEARDOWN in this case. Another option would be to teach ESRestTestCase to clear it between tests, but I don't think that is needed here because we don't commonly set this in tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nik9000 I've made that change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need POST /_ml/set_upgrade_mode?enabled=true to still be a user visible snippet. Only POST /_ml/set_upgrade_mode?enabled=false should be a secret TEARDOWN snippet. (I guess this is also complicated because close-ml.asciidoc gets included in other docs files, and I'm not sure how the TEARDOWNs interact when there are inclusions.)

Copy link
Contributor Author

@lcawl lcawl Feb 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@droberts195 You can preview the changes here:
The snippet is still visible; have I misunderstood your concern?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, yes, the preview looks fine.

--------------------------------------------------
// CONSOLE

//////////////////////////