Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fixes testQueryRandomGeoCollection failure again #39275

Merged

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Feb 21, 2019

Moves the check for tiny polygons earlier in the test. It turned out
that polygons can be so tiny that we cannot even figure out their
orientation.

Relates to #37356

Moves the check for tiny polygons earlier in the test. It turned out
that polygons can be so tiny that we cannot even figure out their
orientation.

Relates to elastic#37356
@imotov imotov added :Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI v7.0.0 v8.0.0 v7.2.0 v6.6.2 labels Feb 21, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@imotov
Copy link
Contributor Author

imotov commented Feb 21, 2019

@elasticmachine run elasticsearch-ci/oss-distro-docs

@imotov imotov requested review from nknize and iverase February 22, 2019 17:00
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for taking care of this. The library can generate unrealistic polygons but glad we can over come it in this way.

@imotov imotov merged commit 078ec27 into elastic:master Feb 25, 2019
imotov added a commit that referenced this pull request Feb 25, 2019
Moves the check for tiny polygons earlier in the test. It turned out
that polygons can be so tiny that we cannot even figure out their
orientation.

Relates to #37356
imotov added a commit that referenced this pull request Feb 25, 2019
Moves the check for tiny polygons earlier in the test. It turned out
that polygons can be so tiny that we cannot even figure out their
orientation.

Relates to #37356
imotov added a commit that referenced this pull request Feb 25, 2019
Moves the check for tiny polygons earlier in the test. It turned out
that polygons can be so tiny that we cannot even figure out their
orientation.

Relates to #37356
imotov added a commit that referenced this pull request Feb 25, 2019
Moves the check for tiny polygons earlier in the test. It turned out
that polygons can be so tiny that we cannot even figure out their
orientation.

Relates to #37356
@imotov imotov deleted the issue-37356-ignore-tiny-polygons-earlier branch May 1, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI v6.6.2 v6.7.0 v7.0.0-rc1 v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants