-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fixes testQueryRandomGeoCollection failure again #39275
Merged
imotov
merged 1 commit into
elastic:master
from
imotov:issue-37356-ignore-tiny-polygons-earlier
Feb 25, 2019
Merged
[CI] Fixes testQueryRandomGeoCollection failure again #39275
imotov
merged 1 commit into
elastic:master
from
imotov:issue-37356-ignore-tiny-polygons-earlier
Feb 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the check for tiny polygons earlier in the test. It turned out that polygons can be so tiny that we cannot even figure out their orientation. Relates to elastic#37356
imotov
added
:Analytics/Geo
Indexing, search aggregations of geo points and shapes
>test-failure
Triaged test failures from CI
v7.0.0
v8.0.0
v7.2.0
v6.6.2
labels
Feb 21, 2019
Pinging @elastic/es-analytics-geo |
@elasticmachine run elasticsearch-ci/oss-distro-docs |
iverase
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for taking care of this. The library can generate unrealistic polygons but glad we can over come it in this way.
imotov
added a commit
that referenced
this pull request
Feb 25, 2019
Moves the check for tiny polygons earlier in the test. It turned out that polygons can be so tiny that we cannot even figure out their orientation. Relates to #37356
imotov
added a commit
that referenced
this pull request
Feb 25, 2019
Moves the check for tiny polygons earlier in the test. It turned out that polygons can be so tiny that we cannot even figure out their orientation. Relates to #37356
imotov
added a commit
that referenced
this pull request
Feb 25, 2019
Moves the check for tiny polygons earlier in the test. It turned out that polygons can be so tiny that we cannot even figure out their orientation. Relates to #37356
imotov
added a commit
that referenced
this pull request
Feb 25, 2019
Moves the check for tiny polygons earlier in the test. It turned out that polygons can be so tiny that we cannot even figure out their orientation. Relates to #37356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/Geo
Indexing, search aggregations of geo points and shapes
>test-failure
Triaged test failures from CI
v6.6.2
v6.7.0
v7.0.0-rc1
v7.2.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the check for tiny polygons earlier in the test. It turned out
that polygons can be so tiny that we cannot even figure out their
orientation.
Relates to #37356