-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CoordinatorTests.testIncompatibleDiffResendsFullState #39345
Conversation
Pinging @elastic/es-distributed |
logger.info("--> healing {}", follower); | ||
follower.heal(); | ||
logger.info("--> submitting second value to {}", leader); | ||
leader.submitValue(randomLong()); | ||
cluster.stabilise(DEFAULT_CLUSTER_STATE_UPDATE_DELAY); | ||
cluster.stabilise(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have an explicit duration here - we do not expect there to be an election so it should not be necessary to wait for a full stabilisation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to suggest such a minimal bound? The point of this test is to check the cluster state diffing logic, not determine any kind of upper bound on stabilization after a follower has been unresponsive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had time to do so, and would rather merge this PR than block on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
logger.info("--> healing {}", follower); | ||
follower.heal(); | ||
logger.info("--> submitting second value to {}", leader); | ||
leader.submitValue(randomLong()); | ||
cluster.stabilise(DEFAULT_CLUSTER_STATE_UPDATE_DELAY); | ||
cluster.stabilise(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had time to do so, and would rather merge this PR than block on that.
This test started failing since decreasing the leader and follower check timeouts (#38298). The reason is that the test was relying on the default publication timeout to come into effect before leader / follower check timeouts, which is now not always true anymore.
Closes #38867