Make integ tests always use runtime java #39732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures cluster formation always uses runtime java, never attempting to use the bundled jdk, since the integ test zip does not contain it.
rjernst
added
>bug
>test
|
Pinging @elastic/es-core-infra |
|
LGTM I'we had to do some specific adjustments to make |
alpar-t
approved these changes
Mar 6, 2019
|
I think we should leave the integ test zip special for now. It will always be special since it is mostly just the server jar, without modules. Not having the bundled jdk is just another facet of that. And I don't think we should complicate it with multiple platforms. |
rjernst
added a commit
that referenced
this pull request
Mar 8, 2019
This commit ensures cluster formation always uses runtime java, never attempting to use the bundled jdk, since the integ test zip does not contain it.
rjernst
added a commit
that referenced
this pull request
Mar 8, 2019
This commit ensures cluster formation always uses runtime java, never attempting to use the bundled jdk, since the integ test zip does not contain it.
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Mar 11, 2019
The changes in elastic#39732 mean that nodes in the IntegTest clusters will now run with whichever java version is defined as `runtime.java` and not JAVA_HOME anymore. This means that these nodes will also run in JVM with fips approved mode enabled and as such, need to have access to the password for the BCFKS keystore that is used as the default keystore/truststore. This change sets the two necessary system properties.
danielmitterdorfer
pushed a commit
that referenced
this pull request
Mar 11, 2019
The changes in #39732 mean that nodes in the IntegTest clusters will now run with whichever java version is defined as `runtime.java` and not JAVA_HOME anymore. This means that these nodes will also run in JVM with fips approved mode enabled and as such, need to have access to the password for the BCFKS keystore that is used as the default keystore/truststore. This change sets the two necessary system properties. Resolves #39855
danielmitterdorfer
pushed a commit
to danielmitterdorfer/elasticsearch
that referenced
this pull request
Mar 11, 2019
The changes in elastic#39732 mean that nodes in the IntegTest clusters will now run with whichever java version is defined as `runtime.java` and not JAVA_HOME anymore. This means that these nodes will also run in JVM with fips approved mode enabled and as such, need to have access to the password for the BCFKS keystore that is used as the default keystore/truststore. This change sets the two necessary system properties. Resolves elastic#39855
danielmitterdorfer
pushed a commit
to danielmitterdorfer/elasticsearch
that referenced
this pull request
Mar 11, 2019
The changes in elastic#39732 mean that nodes in the IntegTest clusters will now run with whichever java version is defined as `runtime.java` and not JAVA_HOME anymore. This means that these nodes will also run in JVM with fips approved mode enabled and as such, need to have access to the password for the BCFKS keystore that is used as the default keystore/truststore. This change sets the two necessary system properties. Resolves elastic#39855
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 12, 2019
The changes in #39732 mean that nodes in the IntegTest clusters will now run with whichever java version is defined as `runtime.java` and not JAVA_HOME anymore. This means that these nodes will also run in JVM with fips approved mode enabled and as such, need to have access to the password for the BCFKS keystore that is used as the default keystore/truststore. This change sets the two necessary system properties. Resolves #39855
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 12, 2019
The changes in #39732 mean that nodes in the IntegTest clusters will now run with whichever java version is defined as `runtime.java` and not JAVA_HOME anymore. This means that these nodes will also run in JVM with fips approved mode enabled and as such, need to have access to the password for the BCFKS keystore that is used as the default keystore/truststore. This change sets the two necessary system properties. Resolves #39855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures cluster formation always uses runtime java, never
attempting to use the bundled jdk, since the integ test zip does not
contain it.