Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SnapshotLifecycleService and related CRUD APIs #39795

Closed
wants to merge 6 commits into from
Closed

Add SnapshotLifecycleService and related CRUD APIs #39795

wants to merge 6 commits into from

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Mar 7, 2019

This commit adds SnapshotLifecycleService as a new service under the ilm
plugin. This service handles snapshot lifecycle policies by scheduling based on
the policies defined schedule.

This also includes the get, put, and delete APIs for these policies

Relates to #38461

@dakrone dakrone added >non-issue :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Mar 7, 2019
@dakrone dakrone requested a review from gwbrown March 7, 2019 15:30
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@dakrone
Copy link
Member Author

dakrone commented Mar 7, 2019 •
edited
Loading

I opened this as a >non-issue because once it is approved I intend to create a feature branch for this, rather than actually merging it to master. This is only a start of the framework for snapshot lifecycle management (and isn't feature-complete), and I'm opening it so we can start by having smaller reviewable chunks of the feature. That's also why there are scattered TODOs in these files for follow-up PRs.

gwbrown
gwbrown requested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments - this looks like a good skeleton, though.

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/scheduler/SchedulerEngine.java Outdated Show resolved Hide resolved
...gin/ilm/src/main/java/org/elasticsearch/xpack/snapshotlifecycle/SnapshotLifecyclePolicy.java Outdated Show resolved Hide resolved
...n/ilm/src/main/java/org/elasticsearch/xpack/snapshotlifecycle/SnapshotLifecycleMetadata.java Outdated Show resolved Hide resolved
...in/ilm/src/main/java/org/elasticsearch/xpack/snapshotlifecycle/SnapshotLifecycleService.java Show resolved Hide resolved
...in/ilm/src/main/java/org/elasticsearch/xpack/snapshotlifecycle/SnapshotLifecycleService.java Show resolved Hide resolved
...c/main/java/org/elasticsearch/xpack/snapshotlifecycle/action/GetSnapshotLifecycleAction.java Outdated Show resolved Hide resolved
...in/ilm/src/main/java/org/elasticsearch/xpack/snapshotlifecycle/SnapshotLifecycleService.java Show resolved Hide resolved
@dakrone
Copy link
Member Author

dakrone commented Mar 12, 2019

@gwbrown thanks for taking a look. I pushed commits addressing your feedback, can you take another look please?

@gwbrown
Copy link
Contributor

gwbrown commented Mar 12, 2019

Thanks @dakrone, most of the changes look good but I left one more comment on the keySet thing.

@dakrone
Copy link
Member Author

dakrone commented Mar 12, 2019

@gwbrown okay, I pushed a commit copying the set.

gwbrown
gwbrown approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming CI is still happy). Thanks!

@dakrone
Copy link
Member Author

dakrone commented Mar 12, 2019

@elasticmachine run elasticsearch-ci/bwc

dakrone added 6 commits March 12, 2019 17:08
@dakrone
Add SnapshotLifecycleService and related CRUD APIs
960041e 
This commit adds `SnapshotLifecycleService` as a new service under the ilm
plugin. This service handles snapshot lifecycle policies by scheduling based on
the policies defined schedule.

This also includes the get, put, and delete APIs for these policies

Relates to elastic#38461
@dakrone
Make scheduledJobIds return an immutable set
acb8135
@dakrone
Use Object.equals for SnapshotLifecyclePolicy
d7b41e0
@dakrone
Remove unneeded TODO
0043de4
@dakrone
Implement ToXContentFragment on SnapshotLifecyclePolicyItem
54ac17c
@dakrone
Copy contents of the scheduledJobIds
c5f7738
@dakrone dakrone force-pushed the snapshot-lifecycle-management branch from 16a76c5 to c5f7738 Compare March 12, 2019 23:08
@dakrone
Copy link
Member Author

dakrone commented Mar 12, 2019

Pushed branch "snapshot-lifecycle-management"

@dakrone dakrone closed this Mar 12, 2019
@dakrone dakrone mentioned this pull request Mar 15, 2019
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwbrown gwbrown gwbrown approved these changes

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >non-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakrone @elasticmachine @gwbrown