Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat TransportService stopped error as node is closing #39800

Merged
merged 3 commits into from
Mar 8, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Mar 7, 2019

If TransportService is stopped before a shard-failure request is sent but after the request is registered, TransportService will notify ReplicationOperation a TransportException with an error message: "transport stop, action: internal:cluster/shard/failure".

CI uncovered this case: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+internalClusterTest/2588/consoleText.

Relates #39584

@dnhatn dnhatn added >bug v7.0.0 :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v6.7.0 v8.0.0 v7.2.0 v6.6.3 labels Mar 7, 2019
@dnhatn dnhatn requested a review from ywelsch March 7, 2019 17:00
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@dnhatn
Copy link
Member Author

dnhatn commented Mar 7, 2019

run elasticsearch-ci/packaging-sample

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn dnhatn merged commit 660c7ed into elastic:master Mar 8, 2019
@dnhatn dnhatn deleted the transport-stopped branch March 8, 2019 17:53
@dnhatn
Copy link
Member Author

dnhatn commented Mar 8, 2019

Thanks Yannick!

dnhatn added a commit that referenced this pull request Mar 8, 2019
If TransportService is stopped before a shard-failure request is sent
but after the request is registered, TransportService will notify
ReplicationOperation a TransportException with an error message:
"transport stop, action: internal:cluster/shard/failure".

Relates #39584
dnhatn added a commit that referenced this pull request Mar 8, 2019
If TransportService is stopped before a shard-failure request is sent
but after the request is registered, TransportService will notify
ReplicationOperation a TransportException with an error message:
"transport stop, action: internal:cluster/shard/failure".

Relates #39584
dnhatn added a commit that referenced this pull request Mar 8, 2019
If TransportService is stopped before a shard-failure request is sent
but after the request is registered, TransportService will notify
ReplicationOperation a TransportException with an error message:
"transport stop, action: internal:cluster/shard/failure".

Relates #39584
dnhatn added a commit that referenced this pull request Mar 11, 2019
If TransportService is stopped before a shard-failure request is sent
but after the request is registered, TransportService will notify
ReplicationOperation a TransportException with an error message:
"transport stop, action: internal:cluster/shard/failure".

Relates #39584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v6.6.3 v6.7.0 v7.0.0-rc2 v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants