[FEATURE] Fix up feature branch after merging master #40094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is possible because there are no BWC concerns
|
Pinging @elastic/ml-core |
droberts195
commented
Mar 15, 2019
| @@ -107,6 +104,8 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| if (parsingException != null) { // Do we have a parsing error? Throw it | |||
| if (parsingException instanceof IOException) { | |||
| throw (IOException) parsingException; | |||
| } else if (parsingException instanceof RuntimeException) { | |||
| throw (RuntimeException) parsingException; | |||
There was a problem hiding this comment.
I added this bit because almost all exceptions used in Elasticsearch are RuntimeExceptions and the bit below that wraps in an ElasticsearchException with no message is not great from the point of view of readability of error responses.
benwtrent
approved these changes
Mar 15, 2019
|
Jenkins run elasticsearch-ci/packaging-sample |
|
The failing packaging test is failing on master too at the moment. Since this PR is only merging to the feature branch I'll merge anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature branch PR
Incorporates feedback from #40060 (review)