Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Writeable for TransportReplAction derivatives #40894

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Use Writeable for TransportReplAction derivatives #40894

merged 2 commits into from
Apr 5, 2019

Conversation

DaveCTurner
Copy link
Contributor

Relates #34389

@DaveCTurner DaveCTurner added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >refactoring v8.0.0 v7.2.0 labels Apr 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

ywelsch
ywelsch approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit 45a6ab0 into elastic:master Apr 5, 2019
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 5, 2019
@DaveCTurner
Use Writeable for TransportReplAction derivatives (elastic#40894)
d0aa5a0 
Relates elastic#34389
@DaveCTurner DaveCTurner mentioned this pull request Apr 5, 2019
Merged
@DaveCTurner DaveCTurner deleted the 2019-04-05-transportreplicationaction-writeables branch April 5, 2019 16:08
DaveCTurner added a commit that referenced this pull request Apr 5, 2019
@DaveCTurner
Use Writeable for TransportReplAction derivatives (#40905)
2ff19bc 
Relates #34389, backport of #40894.
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Apr 6, 2019
@jasontedor
Merge branch 'master' into build-flavor-type-leniency
cad967f 
* master: (63 commits)
  Suppress lease background sync failures if stopping (elastic#40902)
  [DOCS] Added settings page for ILM. (elastic#40880)
  [Docs] Remove extraneous text (elastic#40914)
  Move test classes to test root in Painless (elastic#40873)
  Fix date index name processor default date_formats (elastic#40915)
  Source additional files correctly in elasticsearch-cli (elastic#40890)
  Allow AVX-512 on JDK 11+ (elastic#40828)
  [Docs] Change example to show col headers (elastic#40822)
  Update apache httpclient to version 4.5.8 (elastic#40875)
  Update monitoring-kibana.json (elastic#40899)
  Introduce Delegating ActionListener Wrappers (elastic#40129)
  Deprecate old transport settings (elastic#40821)
  Add Kibana application privileges for monitoring and ml reserved roles (elastic#40651)
  Use Writeable for TransportReplAction derivatives (elastic#40894)
  Add test for HTTP and Transport TLS on basic license (elastic#40714)
  Remove unneded cluster config from test (elastic#40856)
  Make Fuzziness reject illegal values earlier (elastic#33511)
  Remove test-only customisation from TransReplAct (elastic#40863)
  Fix dense/sparse vector limit documentation (elastic#40852)
  Make -try xlint warning disabled by default. (elastic#40833)
  ...
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Apr 6, 2019
@jasontedor
Merge branch 'master' into minimum-java-11
889cf14 
* master: (77 commits)
  Suppress lease background sync failures if stopping (elastic#40902)
  [DOCS] Added settings page for ILM. (elastic#40880)
  [Docs] Remove extraneous text (elastic#40914)
  Move test classes to test root in Painless (elastic#40873)
  Fix date index name processor default date_formats (elastic#40915)
  Source additional files correctly in elasticsearch-cli (elastic#40890)
  Allow AVX-512 on JDK 11+ (elastic#40828)
  [Docs] Change example to show col headers (elastic#40822)
  Update apache httpclient to version 4.5.8 (elastic#40875)
  Update monitoring-kibana.json (elastic#40899)
  Introduce Delegating ActionListener Wrappers (elastic#40129)
  Deprecate old transport settings (elastic#40821)
  Add Kibana application privileges for monitoring and ml reserved roles (elastic#40651)
  Use Writeable for TransportReplAction derivatives (elastic#40894)
  Add test for HTTP and Transport TLS on basic license (elastic#40714)
  Remove unneded cluster config from test (elastic#40856)
  Make Fuzziness reject illegal values earlier (elastic#33511)
  Remove test-only customisation from TransReplAct (elastic#40863)
  Fix dense/sparse vector limit documentation (elastic#40852)
  Make -try xlint warning disabled by default. (elastic#40833)
  ...
@talevy
Copy link
Contributor

talevy commented Apr 15, 2019

thanks @DaveCTurner! I see a backport was merged. is there another backport pending?

@DaveCTurner
Copy link
Contributor Author

Thanks for the ping @talevy, I forgot to remove the backport pending label here. All done.

gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@DaveCTurner
Use Writeable for TransportReplAction derivatives (elastic#40894)
5112101 
Relates elastic#34389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

@henningandersen henningandersen Awaiting requested review from henningandersen

Assignees
No one assigned
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >refactoring v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DaveCTurner @elasticmachine @talevy @ywelsch @jakelandis