[FEATURE][ML] Add setting for results field name #40927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
|
This depends on elastic/ml-cpp#454 to be merged in |
benwtrent
approved these changes
Apr 8, 2019
| parser.declareString(ConstructingObjectParser.constructorArg(), INDEX); | ||
| parser.declareStringOrNull(ConstructingObjectParser.optionalConstructorArg(), RESULTS_FIELD); |
There was a problem hiding this comment.
declareStringOrNull I think implies that the passed argument could be explicitly null. This means results_field: null is a valid payload. This does not make sense to me. It seems to be that it being optional is good so we can set the default, but allowing it to be explicitly null and then overwriting it seems strange to me.
There was a problem hiding this comment.
Ah, yes! Good spot! I got tricked to think it was the method to use for optional fields.
|
Jenkins run elasticsearch-ci/2 |
|
Jenkins run elasticsearch-ci/packaging-sample |
|
run elasticsearch-ci/2 |
dimitris-athanasiou
force-pushed
the
add-setting-for-results-field-name
branch
2 times, most recently
from
7ae73a3 to
e731d06
Compare
Adds a field in the config `dest.results_field` which defaults to `ml`. Results will be written into an object that is named after the results field. In addition, upon starting the analytics there is now validation that the source index does not already have a field matching the results field name. This allows composability of different analytics runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a field in the config
dest.results_fieldwhichdefaults to
ml. Results will be written into an objectthat is named after the results field. In addition,
upon starting the analytics there is now validation that
the source index does not already have a field matching
the results field name.
This allows composability of different analytics runs.