Allow non-exact query types on the root JSON field. #41290
Conversation
jtibshirani
added
>enhancement
:Search Foundations/Mapping
|
Pinging @elastic/es-search |
| throw new UnsupportedOperationException("[fuzzy] queries are not currently supported on [" + | ||
| CONTENT_TYPE + "] fields."); | ||
| throw new UnsupportedOperationException("[fuzzy] queries are not currently supported on keyed " + | ||
| "[" + CONTENT_TYPE + "] fields."); |
There was a problem hiding this comment.
I don't know what is your plan on this but it should be possible to allow this type of query by adding the field prefix in the fuzzy query and change the prefixLength to be prefixLength + field.length + 1 ?
| throw new UnsupportedOperationException("[regexp] queries are not currently supported on [" + | ||
| CONTENT_TYPE + "] fields."); | ||
| throw new UnsupportedOperationException("[regexp] queries are not currently supported on keyed " + | ||
| "[" + CONTENT_TYPE + "] fields."); |
There was a problem hiding this comment.
Same here, just adding the field prefix should work ?
There was a problem hiding this comment.
Do you think it'd make sense to automatically adjust maxDeterminizedStates as well?
There was a problem hiding this comment.
let's keep the value as is, the field name shouldn't consume a lot of states and the current limit is already high (10,000).
| throw new UnsupportedOperationException("[wildcard] queries are not currently supported on [" + | ||
| CONTENT_TYPE + "] fields."); | ||
| throw new UnsupportedOperationException("[wildcard] queries are not currently supported on keyed " + | ||
| "[" + CONTENT_TYPE + "] fields."); |
|
I was planning some future work to support these queries on the keyed field. However maybe it's not as difficult as I thought and I could just add it to this PR. The only slight difficulty I saw was that the keys are allowed to contain characters such as |
Thanks, I missed the escaping part. I am fine either way but feel free to merge this pr and we can have a follow up to discuss the keyed field part. |
|
@elasticmachine run elasticsearch-ci/2 |
|
Thanks @jimczi, I've decided to merge this as-is. |
In an earlier iteration of the design, it made sense to disallow these query types on the root JSON field. It should now it be fine to allow them.
In an earlier iteration of the design, it made sense to disallow these query types on the root JSON field. It should now it be fine to allow them.
In an earlier iteration of the design, it made sense to disallow these query types on the root JSON field. It should now it be fine to allow them.
In an earlier iteration of the design, it made sense to disallow these query
types on the root JSON field. It should now it be fine to allow them.