[ML] fix array oob in IDGenerator and adjust format for mapping #41703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
davidkyle
approved these changes
May 1, 2019
| @@ -234,8 +234,8 @@ public void testDateHistogramPivot() throws Exception { | |||
|
|
|||
| // we expect 21 documents as there shall be 21 days worth of docs | |||
There was a problem hiding this comment.
nit remove or update the comment
There was a problem hiding this comment.
lulz. Maybe I should just stop writing comments :D
davidkyle
approved these changes
May 1, 2019
|
run elasticsearch-ci/bwc |
…ent/elasticsearch into feature/ml-df-fix-oob-format-bugs
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 1, 2019
…tic#41703) * [ML] fix array oob in IDGenerator and adjust format for mapping * Update DataFramePivotRestIT.java
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
…tic#41703) * [ML] fix array oob in IDGenerator and adjust format for mapping * Update DataFramePivotRestIT.java
benwtrent
added a commit
that referenced
this pull request
May 2, 2019
…) (#41717) * [ML] fix array oob in IDGenerator and adjust format for mapping * Update DataFramePivotRestIT.java
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…tic#41703) * [ML] fix array oob in IDGenerator and adjust format for mapping * Update DataFramePivotRestIT.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two bugs addressed here:
""empty string). We should handle that scenario by not allowing the byte array to be emptydate_histogramgroup by pivot, we do not consider it when we create the mapping. We should add their provided format as one of the possible formats for the resultingdatefield.closes #41694