-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML][Data Frame] Add support for allow_no_match for endpoints #43490
Merged
benwtrent
merged 6 commits into
elastic:master
from
benwtrent:feature/ml-df-add-allow_no_match
Jun 26, 2019
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9c49767
[ML][Data Frame] Add support for allow_no_transforms for endpoints
benwtrent 483a4dd
adjusting the stop request ctor
benwtrent b4eccd6
changing to allow_no_match
benwtrent e72629a
Merge branch 'master' into feature/ml-df-add-allow_no_match
benwtrent 28e7552
further renaming of methods and vars
benwtrent f0f7a46
Merge branch 'master' into feature/ml-df-add-allow_no_match
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ | |
public class GetDataFrameTransformStatsRequest implements Validatable { | ||
private final String id; | ||
private PageParams pageParams; | ||
private Boolean allowNoTransforms; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be less confusing to also rename the member variable. |
||
|
||
public GetDataFrameTransformStatsRequest(String id) { | ||
this.id = id; | ||
|
@@ -46,6 +47,14 @@ public void setPageParams(PageParams pageParams) { | |
this.pageParams = pageParams; | ||
} | ||
|
||
public Boolean getAllowNoMatch() { | ||
return allowNoTransforms; | ||
} | ||
|
||
public void setAllowNoMatch(Boolean allowNoTransforms) { | ||
this.allowNoTransforms = allowNoTransforms; | ||
} | ||
|
||
@Override | ||
public Optional<ValidationException> validate() { | ||
if (id == null) { | ||
|
@@ -59,7 +68,7 @@ public Optional<ValidationException> validate() { | |
|
||
@Override | ||
public int hashCode() { | ||
return Objects.hash(id, pageParams); | ||
return Objects.hash(id, pageParams, allowNoTransforms); | ||
} | ||
|
||
@Override | ||
|
@@ -72,6 +81,8 @@ public boolean equals(Object obj) { | |
return false; | ||
} | ||
GetDataFrameTransformStatsRequest other = (GetDataFrameTransformStatsRequest) obj; | ||
return Objects.equals(id, other.id) && Objects.equals(pageParams, other.pageParams); | ||
return Objects.equals(id, other.id) | ||
&& Objects.equals(pageParams, other.pageParams) | ||
&& Objects.equals(allowNoTransforms, other.allowNoTransforms); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,7 @@ public class StopDataFrameTransformRequest implements Validatable { | |
private final String id; | ||
private Boolean waitForCompletion; | ||
private TimeValue timeout; | ||
private Boolean allowNoTransforms; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be less confusing to also rename the member variable. |
||
|
||
public StopDataFrameTransformRequest(String id) { | ||
this.id = id; | ||
|
@@ -64,6 +65,14 @@ public TimeValue getTimeout() { | |
return timeout; | ||
} | ||
|
||
public Boolean getAllowNoMatch() { | ||
return allowNoTransforms; | ||
} | ||
|
||
public void setAllowNoMatch(Boolean allowNoTransforms) { | ||
this.allowNoTransforms = allowNoTransforms; | ||
} | ||
|
||
@Override | ||
public Optional<ValidationException> validate() { | ||
if (id == null) { | ||
|
@@ -77,7 +86,7 @@ public Optional<ValidationException> validate() { | |
|
||
@Override | ||
public int hashCode() { | ||
return Objects.hash(id, waitForCompletion, timeout); | ||
return Objects.hash(id, waitForCompletion, timeout, allowNoTransforms); | ||
} | ||
|
||
@Override | ||
|
@@ -92,7 +101,8 @@ public boolean equals(Object obj) { | |
StopDataFrameTransformRequest other = (StopDataFrameTransformRequest) obj; | ||
return Objects.equals(this.id, other.id) | ||
&& Objects.equals(this.waitForCompletion, other.waitForCompletion) | ||
&& Objects.equals(this.timeout, other.timeout); | ||
&& Objects.equals(this.timeout, other.timeout) | ||
&& Objects.equals(this.allowNoTransforms, other.allowNoTransforms); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be less confusing to also rename the member variable.