-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML][Data Frame] removing format support in date_histogram group_by #43659
Merged
benwtrent
merged 1 commit into
elastic:master
from
benwtrent:feature/ml-df-remove-support-for-format
Jun 28, 2019
Merged
[ML][Data Frame] removing format support in date_histogram group_by #43659
benwtrent
merged 1 commit into
elastic:master
from
benwtrent:feature/ml-df-remove-support-for-format
Jun 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core |
benwtrent
changed the title
[ML][Data Frame] removing format support
[ML][Data Frame] removing format support in date_histogram group_by
Jun 26, 2019
run elasticsearch-ci/1 |
droberts195
approved these changes
Jun 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jun 28, 2019
benwtrent
added a commit
that referenced
this pull request
Jun 28, 2019
@benwtrent Since this is a breaking change, could you add a mention to it in the 7.3 migration guide? |
This was referenced Jul 31, 2019
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
format
support from thedate_histogram
group by. Verifying all references are removed.The submission of a
format
field should be removed from kibana before this PR is merged.Related to: elastic/kibana#39250
Blocked by: elastic/kibana#39811