Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cumulative Cardinality agg (and Data Science plugin) #43661
Add Cumulative Cardinality agg (and Data Science plugin) #43661
Changes from 3 commits
31d9388
f8e3522
1cc0fa8
c754b0f
32f065b
faaf31c
1644c4d
0d1d420
7f43446
0194f82
df49b5d
2a62fdc
2e3772d
afbb0e8
1732a76
2a914a6
4a11563
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't think all this stuff is needed, since you can't go from Basic+ to OSS without uninstalling/reinstalling (I think). So there's no need to watch and cache license changes for a Basic+ feature here.
Will verify and adjust accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's still needed, at least until #45022 is resolved.