Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redundant Setting of OP_WRITE Interest (#43653) #44255

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

original-brownbear
Copy link
Member

  • Remove Redundant Setting of OP_WRITE Interest

  • We shouldn't have to set OP_WRITE interest before running into a partial write. Since setting OP_WRITE is handled by the eventHandler.postHandling logic, I think we can simply remove this operation and simplify/remove tests that were testing the setting of the write interest

backport of #43653

* Remove Redundant Setting of OP_WRITE Interest

* We shouldn't have to set OP_WRITE interest before running into a partial write. Since setting OP_WRITE is handled by the `eventHandler.postHandling` logic, I think we can simply remove this operation and simplify/remove tests that were testing the setting of the write interest
@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/packaging-sample

1 similar comment
@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/packaging-sample

@original-brownbear original-brownbear merged commit d2407d0 into elastic:7.x Jul 12, 2019
@original-brownbear original-brownbear deleted the 43653-7.x branch July 12, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant