-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump exceptions from build tools integ tests #45811
Conversation
The build-tools integ tests (ie testKit) are special and do not have the normal test setup that the rest of the projects get. This commit adds full exception dumping when build tools integ tests fail.
Pinging @elastic/es-core-infra |
I'm not entirely sure if the additional info will be relevant. |
The details we need are not available right now. For example, this failure: https://gradle-enterprise.elastic.co/s/ipm7fzwgvimrq/console-log?task=:build-tools:integTest The build-tools IT tests are not configured the same as the rest of our tests, specifically around exceptions, which is why we see a truncated stack in that scan. |
I think Alpar is right here. Usually that stacktrace is going to be something like an |
To clarify, I'm not against adding this change to |
We already pass |
I did some more investigation, and discussions with Mark, and see now that this is unfortunately a limitation of GradleRunner. The underlying problem in the earlier linked build was a failure talking to jcenter, but it only shows up in the junit output, not the console. The proposed change here won't fix that, so I'm closing this. |
The build-tools integ tests (ie testKit) are special and do not have the
normal test setup that the rest of the projects get. This commit adds
full exception dumping when build tools integ tests fail.