Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SLM Retention serialization versions #46509

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Sep 9, 2019

With #46506 backporting SLM retention, this updates master's version
guards for SLM retention.

Relates to #43663

With elastic#46506 backporting SLM retention, this updates master's version
guards for SLM retention.

Relates to elastic#43663
@dakrone dakrone added >non-issue :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 labels Sep 9, 2019
@dakrone dakrone requested a review from gwbrown September 9, 2019 20:11
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

dakrone added a commit to dakrone/elasticsearch that referenced this pull request Sep 9, 2019
SLM retention was merged in elastic#46407 and will be backported in elastic#46506.
This disables BWC tests until both the backport and the version change
in elastic#46509 are merged.
@gwbrown
Copy link
Contributor

gwbrown commented Sep 9, 2019

@dakrone just noticed in going to verify that this hit all the right places that we still need version guards in SnapshotLifecyclePolicy's writeTo:

public void writeTo(StreamOutput out) throws IOException {
out.writeString(this.id);
out.writeString(this.name);
out.writeString(this.schedule);
out.writeString(this.repository);
out.writeMap(this.configuration);
out.writeOptionalWriteable(this.retentionPolicy);
}

And StreamInput constructor:

public SnapshotLifecyclePolicy(StreamInput in) throws IOException {
this.id = in.readString();
this.name = in.readString();
this.schedule = in.readString();
this.repository = in.readString();
this.configuration = in.readMap();
this.retentionPolicy = in.readOptionalWriteable(SnapshotRetentionConfiguration::new);
}

Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

dakrone added a commit that referenced this pull request Sep 10, 2019
SLM retention was merged in #46407 and will be backported in #46506.
This disables BWC tests until both the backport and the version change
in #46509 are merged.
@dakrone dakrone merged commit 1667e5d into elastic:master Sep 10, 2019
@dakrone dakrone deleted the update-slm-retention-serialization branch September 10, 2019 15:08
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Sep 10, 2019
Now that elastic#46506 and elastic#46509 have been merged, BWC tests can be re-enabled.
dakrone added a commit that referenced this pull request Sep 10, 2019
Now that #46506 and #46509 have been merged, BWC tests can be re-enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >non-issue v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants