-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SLM Retention serialization versions #46509
Update SLM Retention serialization versions #46509
Conversation
With elastic#46506 backporting SLM retention, this updates master's version guards for SLM retention. Relates to elastic#43663
Pinging @elastic/es-core-features |
SLM retention was merged in elastic#46407 and will be backported in elastic#46506. This disables BWC tests until both the backport and the version change in elastic#46509 are merged.
@dakrone just noticed in going to verify that this hit all the right places that we still need version guards in SnapshotLifecyclePolicy's Lines 267 to 274 in 56aabcd
And Lines 99 to 106 in 56aabcd
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
Now that elastic#46506 and elastic#46509 have been merged, BWC tests can be re-enabled.
With #46506 backporting SLM retention, this updates master's version
guards for SLM retention.
Relates to #43663