[7.x] [Java.time] Calculate week of a year with ISO rules (#48209) #48349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverting the change introducing IsoLocal.ROOT and introducing IsoCalendarDataProvider that defaults start of the week to Monday and requires minimum 4 days in first week of a year. This extension is using java SPI mechanism and defaults for Locale.ROOT only. It require jvm property java.locale.providers to be set with SPI,COMPAT closes elastic#41670
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
This was referenced Jan 13, 2020
pgomulka
added a commit
that referenced
this pull request
Jan 21, 2020
Adding back accidentally removed jvm option that is required to enforce start of the week = Monday in IsoCalendarDataProvider. Adding a `feature` to yml test in order to skip running it in JDK8 commit that removed it 398c802 commit that backports SystemJvmOptions c4fbda3 relates 7.x backport of code that enforces CalendarDataProvider use #48349
38 tasks
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jun 10, 2020
Adding back accidentally removed jvm option that is required to enforce start of the week = Monday in IsoCalendarDataProvider. Adding a `feature` to yml test in order to skip running it in JDK8 commit that removed it 398c802 commit that backports SystemJvmOptions c4fbda3 relates 7.x backport of code that enforces CalendarDataProvider use elastic#48349
This was referenced Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x:
The difference between 7.x and 8 is that DateFormatters in 7x is using WeekFields.of(Monday,1) instead of WeekFields.of(Locale.ROOT) in 8. This is because in jdk8 the SPI provider won't work (the behavior of calculating weeks remain broken - using Sunday,1)
In 7x but with jdk9+ this works the same as in 8
The problem with calculating wrong week in 7.x and jdk8 remains (unless a user on it's own places a jar with CalendarDataProvider class in jre's ext/lib)