Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Exceptions Thrown by GetSnapshotsResponse #49522

Closed
wants to merge 3 commits into from

Conversation

original-brownbear
Copy link
Member

As asked for in #43462.
I think this is a worthwhile change if only to make tests easier to debug.

Closes #43462

As asked for in elastic#43462.
I think this is a worthwhile change if only to make tests easier to debug.

Closes elastic#43462
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/1

@rjernst rjernst added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label May 4, 2020
@ywelsch
Copy link
Contributor

ywelsch commented May 27, 2020

Is this still something we want to get in?

@original-brownbear
Copy link
Member Author

Maybe, but this PR is way outdated. I'll open a new one at some point. Thanks for pinging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetSnapshotsResponse should re-wrap failed exceptions so callsites are visible in the stacktrace
4 participants