Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DeleteStep retryable #52494

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Conversation

probakowski
Copy link
Contributor

This change marks DeleteStep as retryable and adds test to make sure we really can invoke it again.

This change marks `DeleteStep` as retryable and adds test to make sure we really can invoke it again.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Przemko!

Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this Przemko

@probakowski probakowski merged commit bf8586e into elastic:master Feb 19, 2020
@probakowski probakowski deleted the delete-retryable branch February 19, 2020 18:55
probakowski added a commit to probakowski/elasticsearch that referenced this pull request Feb 19, 2020
* Make DeleteStep retryable

This change marks `DeleteStep` as retryable and adds test to make sure we really can invoke it again.

* Fix unused import

* revert unneeded changes

* test reworked
probakowski added a commit that referenced this pull request Feb 19, 2020
* Make DeleteStep retryable

This change marks `DeleteStep` as retryable and adds test to make sure we really can invoke it again.

* Fix unused import

* revert unneeded changes

* test reworked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants