Fix roles parsing in client nodes sniffer #52888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mades roles pluggable, but never updated the client to account for this. This means that when speaking to a modern cluster, application logs are spammed with warning messages around unrecognized roles. This commit addresses this by accounting for the fact that roles can extend beyond master/data/ingest now.
jasontedor
added
>bug
:Clients/Java Low Level REST Client
|
Pinging @elastic/es-core-features (:Core/Features/Java Low Level REST Client) |
|
@elasticmachine update branch |
dakrone
approved these changes
Feb 27, 2020
| } | ||
|
|
||
| /** | ||
| * Teturns whether or not the node <strong>could</strong> be elected master. | ||
| */ | ||
| public boolean isMasterEligible() { | ||
| return masterEligible; | ||
| return roles.contains("master"); |
There was a problem hiding this comment.
Out of curiosity, should we make these constants since they're hardcoded as strings all over the place? (in separate work, not this PR)
jasontedor
added a commit
that referenced
this pull request
Feb 27, 2020
We mades roles pluggable, but never updated the client to account for this. This means that when speaking to a modern cluster, application logs are spammed with warning messages around unrecognized roles. This commit addresses this by accounting for the fact that roles can extend beyond master/data/ingest now.
jasontedor
added a commit
that referenced
this pull request
Feb 27, 2020
We mades roles pluggable, but never updated the client to account for this. This means that when speaking to a modern cluster, application logs are spammed with warning messages around unrecognized roles. This commit addresses this by accounting for the fact that roles can extend beyond master/data/ingest now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mades roles pluggable, but never updated the client to account for this. This means that when speaking to a modern cluster, application logs are spammed with warning messages around unrecognized roles. This commit addresses this by accounting for the fact that roles can extend beyond master/data/ingest now.
Closes #52864