Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clear Cache API for Searchable Snapshots #53009

Merged
merged 6 commits into from
Mar 3, 2020
Merged

Add Clear Cache API for Searchable Snapshots #53009

merged 6 commits into from
Mar 3, 2020

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Mar 2, 2020 •
edited
Loading

This pull request adds an API to clear the cache used for searchable snapshots:

POST /_searchable_snapshots/cache/clear
POST <index>/_searchable_snapshots/cache/clear

This API is useful in tests or to simply free disk space if needed. Note that this API does not clear cache stats.

Relates #50999

@tlrx tlrx added >enhancement :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Mar 2, 2020
@tlrx tlrx requested a review from DaveCTurner March 2, 2020 14:48
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

DaveCTurner
DaveCTurner approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left four very minor comments.

...asticsearch/xpack/searchablesnapshots/action/AbstractTransportSearchableSnapshotsAction.java Outdated Show resolved Hide resolved
...rg/elasticsearch/xpack/searchablesnapshots/rest/RestClearSearchableSnapshotsCacheAction.java Outdated Show resolved Hide resolved
...ava/org/elasticsearch/xpack/searchablesnapshots/AbstractSearchableSnapshotsRestTestCase.java Outdated Show resolved Hide resolved
...ava/org/elasticsearch/xpack/searchablesnapshots/AbstractSearchableSnapshotsRestTestCase.java Show resolved Hide resolved
@tlrx
Copy link
Member Author

tlrx commented Mar 2, 2020

@elasticmachine run elasticsearch-ci/bwc
@elasticmachine run elasticsearch-ci/oss-distro-docs

@tlrx
Copy link
Member Author

tlrx commented Mar 3, 2020

@elasticmachine run elasticsearch-ci/bwc

@tlrx
Copy link
Member Author

tlrx commented Mar 3, 2020

@elasticmachine update branch

@tlrx tlrx merged commit d713b9e into elastic:feature/searchable-snapshots Mar 3, 2020
@tlrx tlrx deleted the add-clear-cache-api branch March 3, 2020 12:14
@tlrx
Copy link
Member Author

tlrx commented Mar 3, 2020

Thanks David

@tlrx tlrx mentioned this pull request Apr 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tlrx @elasticmachine @DaveCTurner