Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null config in SnapshotLifecyclePolicy.toRequest #53328

Conversation

probakowski
Copy link
Contributor

This avoids NPE when executing SLM policy when no config was provided.

Related to #44465

Closes #53171

This avoids NPE when executing SLM policy when no config was provided.

Related to elastic#44465

Closes elastic#53171
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@probakowski
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @probakowski LGTM

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks @probakowski

@probakowski probakowski merged commit bcb5e0f into elastic:master Mar 10, 2020
@probakowski probakowski deleted the fix-npe-snapshotlifecyclepolicy-torequest branch March 10, 2020 18:36
probakowski added a commit to probakowski/elasticsearch that referenced this pull request Mar 10, 2020
This avoids NPE when executing SLM policy when no config was provided.

Related to elastic#44465

Closes elastic#53171

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
probakowski added a commit to probakowski/elasticsearch that referenced this pull request Mar 10, 2020
This avoids NPE when executing SLM policy when no config was provided.

Related to elastic#44465

Closes elastic#53171

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
probakowski added a commit that referenced this pull request Mar 10, 2020
This avoids NPE when executing SLM policy when no config was provided.

Related to #44465

Closes #53171

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
probakowski added a commit that referenced this pull request Mar 10, 2020
This avoids NPE when executing SLM policy when no config was provided.

Related to #44465

Closes #53171

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoteTransportException caused by NullPointerException when trying to create snapshot through Kibana UI
5 participants