Align remote info api with new settings #53441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the remote info api has added a number of possible fields (proxy, num_socket_connections, etc) that are available in proxy mode. These fields are not aligned with what the settings are named. This commit modifies this API to align with the settings.
Tim-Brooks
added
>non-issue
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed (:Distributed/Network) |
|
This API was not documented in 7.6. And since it is only a REST api, I assume it is okay to change this @ywelsch? |
ywelsch
approved these changes
Mar 13, 2020
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Mar 24, 2020
Currently the remote info api has added a number of possible fields (proxy, num_socket_connections, etc) that are available in proxy mode. These fields are not aligned with what the settings are named. This commit modifies this API to align with the settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the remote info api has added a number of possible fields
(proxy, num_socket_connections, etc) that are available in proxy mode.
These fields are not aligned with what the settings are named. This
commit modifies this API to align with the settings.