-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for distance queries on geo_shape queries #53466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>feature
:Analytics/Geo
Indexing, search aggregations of geo points and shapes
v8.0.0
v7.7.0
labels
Mar 12, 2020
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
nknize
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the cleanup. Simple and easy to follow. Thx @iverase
@elasticmachine run elasticsearch-ci/packaging-sample-matrix-unix |
iverase
added a commit
that referenced
this pull request
Mar 19, 2020
38 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Apr 16, 2020
Relates: elastic/elasticsearch#53466, elastic/elasticsearch#52564 elastic/elasticsearch#53466, elastic/elasticsearch#52133 This commit updates the Skip versions on circle and multipoint geoshape queries, to allow them to run for versions 7.7.0+. Update documentation to indicate that 7.7.0+ is required when geo shapes are indexed using BKD trees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upgrade to Lucene 8.5, LatLonShape field has support for distance queries. This change implements this new feature and removes the limitation.
In addition the strategy for building queries is changed as Lucene adds a new interface method called
LatLonShape.newGeometryQuery
that takes an array of Lucene geometries. This allows the query engine to build the most efficient query for the given parameters. For example an intersect query with a geometry collection currently creates one query per geometry. With this change, the engine can build just one query with all geometries.fixes #39237
closes #13351