Validation for data stream creation #54083
Conversation
danhermann
added
>non-issue
v8.0.0
:Data Management/Data streams
|
Pinging @elastic/es-core-features (:Core/Features/Data streams) |
.../src/main/java/org/elasticsearch/action/admin/indices/datastream/CreateDataStreamAction.java
Outdated
Show resolved
Hide resolved
danhermann
changed the title
server/src/main/java/org/elasticsearch/cluster/metadata/MetaData.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/bwc |
|
@elasticmachine update branch |
server/src/main/java/org/elasticsearch/cluster/metadata/MetaData.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/1 |
| SortedMap<?, ?> map = aliasAndIndexLookup.subMap(ds.getName() + "-", ds.getName() + "."); // '.' is the char after '-' | ||
| if (map.size() != 0) { | ||
| throw new IllegalStateException("data stream [" + ds.getName() + | ||
| "] could create backing indices that conflict with existing indices or aliases"); |
There was a problem hiding this comment.
Should we include the list of conflicting names in the message or at least the first few?
| @@ -165,9 +166,11 @@ static ClusterState createDataStream(ClusterState currentState, Request request) | |||
| throw new IllegalArgumentException("data_stream [" + request.name + "] already exists"); | |||
| } | |||
|
|
|||
| MetaDataCreateIndexService.validateIndexOrAliasName(request.name, | |||
There was a problem hiding this comment.
Should we rename the method to either "validateIndexSpaceName" or "validateAbstractIndexName"? Can be done in a follow-up when the naming discussion is clarified.
| @@ -165,9 +166,11 @@ static ClusterState createDataStream(ClusterState currentState, Request request) | |||
| throw new IllegalArgumentException("data_stream [" + request.name + "] already exists"); | |||
| } | |||
|
|
|||
| MetaDataCreateIndexService.validateIndexOrAliasName(request.name, | |||
| (s1, s2) -> new IllegalArgumentException("data_stream [" + s1 + "] " + s2)); | |||
There was a problem hiding this comment.
The other usages of validateIndexOrAliasName throw a dedicated exception. I am not entirely sure if IllegalArgumentException results in the same RestStatus and message handling. Could we add this to the rest test suite?
There was a problem hiding this comment.
Added a REST test to enforce that the same HTTP 400 response code is returned.
|
@elasticmachine update branch |
|
@elasticmachine update branch |
Prevent name conflicts with existing indices or aliases.
Relates to #53100