Rename MetaData to Metadata in all of the places #54519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple naming change PR, to fix the fact that "metadata" is a single English word, and for too long we have not followed general naming conventions for it. We are also not consistent about it, for example, METADATA instead of META_DATA if we were trying to be consistent with MetaData (although METADATA is correct when considered in the context of "metadata"). This was a simple find and replace across the code base, only taking a few minutes to fix this naming issue forever.
jasontedor
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
|
Not looking at the actual diff given the size of this, but LGTM. We should separately look at having a more clarifying name (what metadata for what?) |
rjernst
approved these changes
Mar 31, 2020
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 31, 2020
This is a simple naming change PR, to fix the fact that "metadata" is a single English word, and for too long we have not followed general naming conventions for it. We are also not consistent about it, for example, METADATA instead of META_DATA if we were trying to be consistent with MetaData (although METADATA is correct when considered in the context of "metadata"). This was a simple find and replace across the code base, only taking a few minutes to fix this naming issue forever.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 4, 2020
We recently cleaned up the use of the word "metadata" across the codebase. A few additional uses have trickled in, likely from in-progress work. This commit cleans up these last few instances. Relates elastic#54519
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 4, 2020
We recently cleaned up the use of the word "metadata" across the codebase. A few additional uses have trickled in, likely from in-progress work. This commit cleans up these last few instances. Relates elastic#54519
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 4, 2020
We recently renamed "metaData" to "metadata" in all of the places. We were slightly aggressive in doing this rename in the SQL codebase where "MetaData" is used by the JDK for its naming of these classes, and we tried to keep SQL consistent with that, but inadvertently renamed a few things that we should not have. Also, since we did not make these renames in the 7.x branch, we should rename them back in the master branch for reasons of consistency too. Relates elastic#54519
jasontedor
added a commit
that referenced
this pull request
Apr 4, 2020
We recently renamed "metaData" to "metadata" in all of the places. We were slightly aggressive in doing this rename in the SQL codebase where "MetaData" is used by the JDK for its naming of these classes, and we tried to keep SQL consistent with that, but inadvertently renamed a few things that we should not have. Also, since we did not make these renames in the 7.x branch, we should rename them back in the master branch for reasons of consistency too. Relates #54519
jasontedor
added a commit
that referenced
this pull request
Apr 7, 2020
We recently cleaned up the use of the word "metadata" across the codebase. A few more additional uses have trickled in, likely from in-progress work. This commit cleans up these last few additional instances. Relates #54519
jasontedor
added a commit
that referenced
this pull request
Apr 10, 2020
We recently cleaned up the use of the word "metadata" across the codebase. Even more additional uses have trickled in, likely from in-progress work. This commit cleans up these last few additional instances. Relates #54519
jasontedor
added a commit
that referenced
this pull request
Apr 10, 2020
We recently cleaned up the use of the word "metadata" across the codebase. Even more additional uses have trickled in, likely from in-progress work. This commit cleans up these last few additional instances. Relates #54519
|
@ywelsch Can you clarify which PR was silently reverted, since you linked back to this PR I can not investigate. 🙏 |
|
urgs, sorry. It was #54407. Looks to only have happened on master (7.x is fine) |
|
I don't know what could have happened here. This change was purely mechanical, and the lines that you're referencing would not have had any merge conflicts with the lines changed in that file in this PR. Interestingly, the way that I did the 7.x change was not to cherry-pick back, but merely to repeat the mechanical steps I took to prepare the change in master too, so it's surprising that those same steps would cause problems in master but not 7.x. Sorry for the trouble, I'm glad that you caught the reversion. |
vhyza
added a commit
to vhyza/elasticsearch-analysis-lemmagen
that referenced
this pull request
Jun 30, 2020
mkleen
added a commit
to crate/crate
that referenced
this pull request
Jul 3, 2020
mkleen
added a commit
to crate/crate
that referenced
this pull request
Jul 3, 2020
Based on elastic/elasticsearch#54519 and also applied in the rest of the code base.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Jul 3, 2020
mkleen
added a commit
to crate/crate
that referenced
this pull request
Jul 3, 2020
Based on elastic/elasticsearch#54519 and also applied in the rest of the code base.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Jul 3, 2020
mkleen
added a commit
to crate/crate
that referenced
this pull request
Jul 3, 2020
Based on elastic/elasticsearch#54519 This also applies it to the rest of the code base and renames META_DATA to METADATA.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Jul 3, 2020
Based on elastic/elasticsearch#54519 This also applies it to the rest of the code base and also renames META_DATA to METADATA.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Jul 3, 2020
Based on elastic/elasticsearch#54519 This also applies it to the rest of the code base and also renames META_DATA to METADATA.
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Jul 3, 2020
Based on elastic/elasticsearch#54519 This also applies it to the rest of the code base and also renames META_DATA to METADATA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple naming change PR, to fix the fact that "metadata" is a single English word, and for too long we have not followed general naming conventions for it. We are also not consistent about it, for example, METADATA instead of META_DATA if we were trying to be consistent with MetaData (although METADATA is correct when considered in the context of "metadata"). This was a simple find and replace across the code base, only taking a few minutes to fix this naming issue forever.