Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle shard closed during prerecovery #54790

Conversation

DaveCTurner
Copy link
Contributor

Today we assert that the shard is in state RECOVERING during prerecovery, but
the recovery may already have been cancelled by a subsequent cluster state
update. This commit adds handling for this cancellation.

Relates #50999.

Today we assert that the shard is in state RECOVERING during prerecovery, but
the recovery may already have been cancelled by a subsequent cluster state
update. This commit adds handling for this cancellation.
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Apr 6, 2020
@DaveCTurner DaveCTurner requested a review from tlrx April 6, 2020 09:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner
Copy link
Contributor Author

Failure is unrelated; @elasticmachine please run elasticsearch-ci/1

@DaveCTurner DaveCTurner merged commit 3455e0c into elastic:feature/searchable-snapshots Apr 6, 2020
@DaveCTurner DaveCTurner deleted the 2020-04-06-allow-shard-closing-during-prerecovery branch April 6, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants