Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redundant Cluster State during Snapshot INIT + Master Failover (#54420) #55208

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

original-brownbear
Copy link
Member

@original-brownbear original-brownbear commented Apr 15, 2020

  • Remove Redundant Cluster State during Snapshot INIT + Master Failover

Similar to #54395 we know that a snapshot in INIT state has not
written anything to the repository yet. If we see one from a master
failover, there is no point in moving it to ABORTED before removing it
from the cluster state in a subsequent CS update.
Instead, we can simply remove its job from the CS the first time
we see it on master failover and be done with it.

backport of #54420

Note: for the backport we need to keep the cleanup code because in a mixed cluster containing 6.x we could have still written data to the repo on INIT so we set the flag for the cleanup to true on the bwc path

…elastic#54420)

* Remove Redundant Cluster State during Snapshot INIT + Master Failover

Similar to elastic#54395 we know that a snapshot in INIT state has not
written anything to the repository yet. If we see one from a master
failover, there is no point in moving it to ABORTED before removing it
from the cluster state in a subsequent CS update.
Instead, we can simply remove its job from the CS the first time
we see it on master failover and be done with it.
@original-brownbear original-brownbear added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs backport labels Apr 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/2 (some ML issue)

1 similar comment
@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/2 (some ML issue)

@original-brownbear original-brownbear merged commit e164c9a into elastic:7.x Apr 15, 2020
@original-brownbear original-brownbear deleted the 54395-7.x branch April 15, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants