Default to zero replicas for searchable snapshots #57802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today a mounted searchable snapshot defaults to having the same replica configuration as the index that was snapshotted. This commit changes this behaviour so that we default to zero replicas on these indices, but allow the user to override this in the mount request. Relates elastic#50999
DaveCTurner
added
>enhancement
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
elasticmachine
added
the
Team:Distributed (Obsolete)
tlrx
approved these changes
Jun 9, 2020
| @@ -153,6 +154,9 @@ public void testCreateAndRestoreSearchableSnapshot() throws Exception { | |||
| new ByteSizeValue(randomLongBetween(10, 100_000)) | |||
| ); | |||
| } | |||
| if (randomBoolean()) { | |||
There was a problem hiding this comment.
Can we capture the number of replica that it randomly set and checks once the index is mounted that it corresponds?
| .cluster() | ||
| .preparePutRepository(fsRepoName) | ||
| .setType("fs") | ||
| .setSettings(Settings.builder().put("location", repo).put("chunk_size", randomIntBetween(100, 1000), ByteSizeUnit.BYTES)) |
There was a problem hiding this comment.
The chunk_size can introduces many more writes and files, so maybe we can jut remove for this test?
| final Settings.Builder originalIndexSettings = Settings.builder(); | ||
| originalIndexSettings.put(INDEX_SOFT_DELETES_SETTING.getKey(), true); | ||
| if (randomBoolean()) { | ||
| originalIndexSettings.put(IndexMetadata.SETTING_NUMBER_OF_REPLICAS, between(0, dataNodesCount - 1)); |
There was a problem hiding this comment.
I think we can use minimumNumberOfReplicas / maximumNumberOfReplicas here?
DaveCTurner
deleted the
2020-06-08-searchable-snapshot-defaults-to-no-replicas
branch
DaveCTurner
added a commit
that referenced
this pull request
Jun 16, 2020
Today a mounted searchable snapshot defaults to having the same replica configuration as the index that was snapshotted. This commit changes this behaviour so that we default to zero replicas on these indices, but allow the user to override this in the mount request. Relates #50999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today a mounted searchable snapshot defaults to having the same replica
configuration as the index that was snapshotted. This commit changes this
behaviour so that we default to zero replicas on these indices, but allow the
user to override this in the mount request.
Relates #50999