Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing params to template or script failed in watcher #58559

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Fix passing params to template or script failed in watcher #58559

merged 2 commits into from
Sep 2, 2020

Conversation

gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Jun 25, 2020 •
edited
Loading

Relates to #57625.

The main changes are:

  1. Fix custom params are missing when using template or script in watcher's logging action or jira action.
  2. Add yaml tests to test passing params to template or script successfully.

@gaobinlong gaobinlong changed the title Fix passing params to template or script failed Fix passing params to template or script failed in watcher Jun 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Watcher)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 30, 2020
@jakelandis jakelandis self-requested a review July 2, 2020 14:49
@jakelandis
Copy link
Contributor

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

merge conflict between base and head

@jakelandis
Copy link
Contributor

@elasticmachine ok to test

jakelandis
jakelandis approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good. thanks @gaobinlong !

@jakelandis jakelandis merged commit 500e12f into elastic:master Sep 2, 2020
@jakelandis jakelandis mentioned this pull request Sep 2, 2020
Merged
jakelandis pushed a commit to jakelandis/elasticsearch that referenced this pull request Sep 2, 2020
@gaobinlong @jakelandis
Fix passing params to template or script failed in watcher (elastic#5…
3f68873 
…8559)

The main changes are:
* Fix custom params are missing when using template or script in watcher's 
  logging action or jira action.
* Add yaml tests to test passing params to template or script successfully.

Relates to elastic#57625
jakelandis added a commit that referenced this pull request Sep 3, 2020
@jakelandis @gaobinlong
[7.x] Fix passing params to template or script failed in watcher (#58559
ea1e8ad 
) (#61885)

The main changes are:
* Fix custom params are missing when using template or script in watcher's 
  logging action or jira action.
* Add yaml tests to test passing params to template or script successfully.

Relates to #57625

Co-authored-by: bellengao <gbl_long@163.com>
@andreidan andreidan added the >bug label Oct 8, 2020
@joegallo joegallo mentioned this pull request Nov 4, 2020
Closed
@fbaligand
Copy link
Contributor

Nice!
Thanks for the fix!

@Mpdreamz Mpdreamz mentioned this pull request Nov 16, 2020
Closed
61 tasks
@stevejgordon stevejgordon mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis jakelandis approved these changes

Assignees
No one assigned
Labels
>bug :Data Management/Watcher Team:Data Management Meta label for data/management team v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gaobinlong @elasticmachine @jakelandis @fbaligand @andreidan @cbuescher