ILM: add frozen phase #60983
Merged
ILM: add frozen phase #60983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a frozen phase to ILM that will allow the execution of the set_priority, unfollow, allocate, freeze and searchable_snapshot actions. The frozen phase will be executed after the cold and before the delete phase.
andreidan
added
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
elasticmachine
added
the
Team:Data Management
|
Can you add an integration test for this also? Just something that makes sure the parsing and all that for |
18 tasks
@dakrone I've added a frozen phase to the full policy we use in integration tests (so an allocation action will be executed in the frozen phase in a few integration tests already) https://github.com/elastic/elasticsearch/pull/60983/files#diff-10033c7c446c648bcb131cf7ad168cbdR170 Do you think we need to add more phase based testing? |
|
@andreidan for some reason I was thinking that was transport based rather than REST based, so nevermind on that! |
dakrone
approved these changes
Aug 12, 2020
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Aug 12, 2020
This adds a frozen phase to ILM that will allow the execution of the set_priority, unfollow, allocate, freeze and searchable_snapshot actions. The frozen phase will be executed after the cold and before the delete phase. (cherry picked from commit 6d01480) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan
added a commit
that referenced
this pull request
Aug 12, 2020
This adds a frozen phase to ILM that will allow the execution of the set_priority, unfollow, allocate, freeze and searchable_snapshot actions. The frozen phase will be executed after the cold and before the delete phase. (cherry picked from commit 6d01480) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Sep 15, 2020
With the differentiation between searchable snapshots on the cold phase and searchable snapshots on the frozen phase not implemented, there is no need to have a separate phase/tier for now. This commit removes the frozen phase and tier, which can be added back at a later time. (this tier was never in a released version, so this is not a breaking change) Relates to elastic#60983 Relates to elastic#60994 Relates to elastic#60848
dakrone
added a commit
that referenced
this pull request
Sep 16, 2020
With the differentiation between searchable snapshots on the cold phase and searchable snapshots on the frozen phase not implemented, there is no need to have a separate phase/tier for now. This commit removes the frozen phase and tier, which can be added back at a later time. (this tier was never in a released version, so this is not a breaking change) Relates to #60983 Relates to #60994 Relates to #60848
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Sep 16, 2020
With the differentiation between searchable snapshots on the cold phase and searchable snapshots on the frozen phase not implemented, there is no need to have a separate phase/tier for now. This commit removes the frozen phase and tier, which can be added back at a later time. (this tier was never in a released version, so this is not a breaking change) Relates to elastic#60983 Relates to elastic#60994 Relates to elastic#60848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a frozen phase to ILM that will allow the execution of the
set_priority, unfollow, allocate, freeze and searchable_snapshot actions.
The frozen phase will be executed after the cold and before the delete phase.
Relates to #60848