-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a redundant section on field data types. #61821
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All information in the section is already included in the 'mapping-types' page.
jtibshirani
added
>docs
General docs changes
:Search Foundations/Mapping
Index mappings, including merging and defining field types
v8.0.0
v7.10.0
v7.9.2
labels
Sep 1, 2020
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-search (:Search/Mapping) |
elasticmachine
added
Team:Docs
Meta label for docs team
Team:Search
Meta label for search team
labels
Sep 1, 2020
If this is approved, then I'll update es-hadoop to avoid linking to the deleted section. This should fix the build failures. |
jrodewig
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
jtibshirani
added a commit
to elastic/elasticsearch-hadoop
that referenced
this pull request
Sep 2, 2020
We're removing this subsection in the ES docs in elastic/elasticsearch#61821. This PR updates the links to reference the main field types page.
jtibshirani
added a commit
to elastic/elasticsearch-hadoop
that referenced
this pull request
Sep 2, 2020
We're removing this subsection in the ES docs in elastic/elasticsearch#61821. This PR updates the links to reference the main field types page.
jtibshirani
added a commit
to elastic/elasticsearch-hadoop
that referenced
this pull request
Sep 2, 2020
We're removing this subsection in the ES docs in elastic/elasticsearch#61821. This PR updates the links to reference the main field types page.
@elasticmachine run elasticsearch-ci/docs |
jtibshirani
added a commit
that referenced
this pull request
Sep 2, 2020
All information in the section is already included in the 'mapping-types' page.
jtibshirani
added a commit
that referenced
this pull request
Sep 2, 2020
All information in the section is already included in the 'mapping-types' page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>docs
General docs changes
:Search Foundations/Mapping
Index mappings, including merging and defining field types
Team:Docs
Meta label for docs team
Team:Search
Meta label for search team
v7.9.2
v7.10.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All information in the section is already included in the 'mapping-types' page.