Allow_duplicates option for append processor #61916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
added
>enhancement
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
1 similar comment
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
probakowski
approved these changes
Sep 4, 2020
There was a problem hiding this comment.
LGTM, thanks @danhermann!
I left one super minor nit, you can skip it if you want
Comment on lines
+206
to
+207
| List.of(new UppercaseProcessor("_tag_upper", null, "_ingest._value", false, "_ingest._value")), | ||
| List.of(new AppendProcessor("_tag", null, template, (model) -> (Collections.singletonList("added")), true)) |
There was a problem hiding this comment.
I'd stick with Collections.singletonList just for the sake of backporting
There was a problem hiding this comment.
The Java8-compatible implementations of List, Set, and Map in the collect package make these backports pretty easy.
|
Thanks for the review, @probakowski! |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Sep 14, 2020
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Oct 5, 2020
danhermann
added a commit
that referenced
this pull request
Oct 6, 2020
This was referenced Oct 8, 2020
61 tasks
stevejgordon
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Dec 22, 2020
stevejgordon
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 7, 2021
* Support allow_duplicates on append processor Related to elastic/elasticsearch#61916
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 7, 2021
* Support allow_duplicates on append processor Related to elastic/elasticsearch#61916
stevejgordon
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 7, 2021
* Support allow_duplicates on append processor Related to elastic/elasticsearch#61916 (cherry picked from commit 2b75c5e)
stevejgordon
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 7, 2021
* Support allow_duplicates on append processor Related to elastic/elasticsearch#61916 Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jan 7, 2021
* Support allow_duplicates on append processor Related to elastic/elasticsearch#61916 (cherry picked from commit 2b75c5e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
allow_duplicatesoption to the append processor. When set tofalse, any of the values to be appended that are already present in the target field will be ignored. Defaults totrueto preserve existing behavior.Closes #57543